Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Introduction section of Home Page #178

Closed
wants to merge 2 commits into from

Conversation

tichnas
Copy link
Contributor

@tichnas tichnas commented Dec 12, 2020

Description

Introduction section of the Home Page is developed with links to Medium, Github and Zulip.
The code takes data dynamically from a file src/content/home.js, but the real content is not yet added (#108)

Fixes #109

Type of Change:

  • Code
  • User Interface
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

recording(3)-min

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

},
content: {
par:
'Lorem ipsum dolor sit amet consectetur, adipisicing elit. Quis omnis minus, quisquam ab architecto dolor hic dolores, ducimus explicabo, voluptates fugit dolorum itaque enim nam. Enim nulla, vitae recusandae est pariatur consequuntur aperiam molestiae, minus vero, fugiat ipsam facilis cupiditate alias dolorem mollitia officiis. Excepturi, blanditiis?',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why random text is used here? Is it intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. The real content is not there yet, so I used random text. I've also updated the description to inform this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no Lorem ipsum will be merged. Rise issue and wait for content or write content by your own. Thanks!

Copy link
Contributor

@annabauza annabauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that, however no Lorem ipsum will be merged. Also it feels like sometimes text is touching the image. Can you please make a testing version following those steps and ping our testing team. Thank you.

@tichnas
Copy link
Contributor Author

tichnas commented Dec 22, 2020

@annabauza You're right about the text touching the images. It's a bug in an already build component (ImageContent) and I've created an issue (#167) for this which is solved in PR #170

@annabauza annabauza added the Status: Changes Requested Changes are required to be done by the PR author. label Dec 23, 2020
@Vishal-raj-1
Copy link

@tichnas any updates ?

Copy link
Contributor

@annabauza annabauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace Lorem ipsum with real paragraph text.

},
content: {
par:
'Lorem ipsum dolor sit amet consectetur, adipisicing elit. Quis omnis minus, quisquam ab architecto dolor hic dolores, ducimus explicabo, voluptates fugit dolorum itaque enim nam. Enim nulla, vitae recusandae est pariatur consequuntur aperiam molestiae, minus vero, fugiat ipsam facilis cupiditate alias dolorem mollitia officiis. Excepturi, blanditiis?',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no Lorem ipsum will be merged. Rise issue and wait for content or write content by your own. Thanks!

@annabauza
Copy link
Contributor

@tichnas I close this PR due to lack of respond.

@annabauza annabauza closed this Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coding : Develop Introduction section of Home Page
4 participants