-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Introduction section of Home Page #178
Conversation
}, | ||
content: { | ||
par: | ||
'Lorem ipsum dolor sit amet consectetur, adipisicing elit. Quis omnis minus, quisquam ab architecto dolor hic dolores, ducimus explicabo, voluptates fugit dolorum itaque enim nam. Enim nulla, vitae recusandae est pariatur consequuntur aperiam molestiae, minus vero, fugiat ipsam facilis cupiditate alias dolorem mollitia officiis. Excepturi, blanditiis?', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why random text is used here? Is it intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. The real content is not there yet, so I used random text. I've also updated the description to inform this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no Lorem ipsum
will be merged. Rise issue and wait for content or write content by your own. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for that, however no Lorem ipsum will be merged. Also it feels like sometimes text is touching the image. Can you please make a testing version following those steps and ping our testing team. Thank you.
@annabauza You're right about the text touching the images. It's a bug in an already build component ( |
@tichnas any updates ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace Lorem ipsum with real paragraph text.
}, | ||
content: { | ||
par: | ||
'Lorem ipsum dolor sit amet consectetur, adipisicing elit. Quis omnis minus, quisquam ab architecto dolor hic dolores, ducimus explicabo, voluptates fugit dolorum itaque enim nam. Enim nulla, vitae recusandae est pariatur consequuntur aperiam molestiae, minus vero, fugiat ipsam facilis cupiditate alias dolorem mollitia officiis. Excepturi, blanditiis?', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no Lorem ipsum
will be merged. Rise issue and wait for content or write content by your own. Thanks!
@tichnas I close this PR due to lack of respond. |
Description
Introduction section of the Home Page is developed with links to Medium, Github and Zulip.
The code takes data dynamically from a file
src/content/home.js
, but the real content is not yet added (#108)Fixes #109
Type of Change:
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only