Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Streamwise messages not showing on zulip stat card to admin #72

Open
codesankalp opened this issue Feb 8, 2021 · 22 comments
Open
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Hacktoberfest

Comments

@codesankalp
Copy link
Member

Describe the bug

Streamwise messages are not showing on zulip stat to admin because the condition to check streamwise messages is wrong.
We need to delete this condition of checking all streamwise messages by checking the message in the newcomer stream, as it is not required. To test the message

To Reproduce

Steps to reproduce the behavior:

  1. Go to http://localhost:8000/admin/osp/userinformation/
  2. Edit one of the admin user-information and insert 345277 in zulip id.
  3. Now go to this http://localhost:3000/ and log in using the credentials of the user which you have edited previously.
  4. Reload the zulip stats and now you can see that streamwise messages do not show up.

Expected behavior

Streamwise messages do not show up when the student has no message in the newcomer stream.

Screenshots

image

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Chrome
  • Version: _

How to solve

To solve this issue remove the condition of checking the stream messages by checking message in newcomer stream.
https://github.com/anitab-org/open-source-programs-web/blob/ab18727af5a5e30829e4d07935a218c6d8a02762/src/components/Zulip.js#L39-L51

I have tested by removing it, it is working fine.

Time Required to solve this issue

  • 10 to 15 minutes.
@codesankalp codesankalp changed the title Streamwise messages not showing on zulip stat card to admin Bug: Streamwise messages not showing on zulip stat card to admin Feb 8, 2021
@codesankalp
Copy link
Member Author

@isabelcosta Can you please add labels to this issue?
As It is a beginner issue so a newcomer can solve this issue ☺️

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Feb 9, 2021
@isabelcosta
Copy link
Member

thank you @codesankalp for helping triage!

@prachinandi
Copy link

@isabelcosta Ma'am if this issue is not assigned can I take it

@isabelcosta
Copy link
Member

yes @prachi237 🤗 Will assign it to you!

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 11, 2021
@prachinandi
Copy link

Thanku ma'am😊

@codesankalp
Copy link
Member Author

@prachi237 Any updates on this issue? Do you need any help or suggestion?

@prachinandi
Copy link

@prachi237 Any updates on this issue? Do you need any help or suggestion?
😅sorry, for the delay I had exams, I started working on this issue again . Will send the PR asap

@codesankalp
Copy link
Member Author

@prachi237 Is your exams over and can you make a PR on this?

@codesankalp
Copy link
Member Author

Unassigning @prachi237 due to inactivity.

@codesankalp codesankalp added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 12, 2021
@sidharth3000
Copy link

if this is still available can i take this?

@Aaishpra
Copy link
Member

Yess it is assigned you here, Do ask if you have any doubts

@sidharth3000
Copy link

project is not setting up, its giving me error.
Screenshot 2021-05-20 231846

@codesankalp
Copy link
Member Author

Have you setup the backend correctly and is it running?

@sidharth3000
Copy link

yes now its running, i had to bump up several dependencies. Now if i am not wrong i just have to remove this line. is it right?
Screenshot 2021-05-21 172530

@vj-codes
Copy link
Member

@sidharth3000 any updates?

@isabelcosta
Copy link
Member

@sidharth3000 removed your assignment due to a lack of activity. Feel free to claim again, if you want to work on it

@msaini28r
Copy link

@isabelcosta can you assign this issue to me?

@codesankalp codesankalp removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Oct 14, 2021
@isabelcosta
Copy link
Member

@msaini0r , @codesankalp assigned this ticket to you :)

@msaini28r msaini28r mentioned this issue Oct 15, 2021
5 tasks
@msaini28r
Copy link

@isabelcosta please merge the pull request.

@indravijay-bot
Copy link

if this is still available can i take this?

@ASP124
Copy link

ASP124 commented Sep 14, 2023

Hello @codesankalp, I request you to grant me the access to work on this issue.
Regards ASP

@codesankalp codesankalp assigned ASP124 and unassigned msaini28r Sep 14, 2023
@AaryaDarisi
Copy link

AaryaDarisi commented Feb 23, 2024

Hey @codesankalp, @isabelcosta i see that the issue is still open and left since a while and so i want to take this up if it is available but before picking it i wanted to ask if the steps mentioned in the HOW TO SOLVE section of the description is up to date coz i see that @msaini28r had followed it and ran into some issues. I wanted to confirm before starting to not to waste your time.
Thank you!

@msaini28r msaini28r mentioned this issue on Oct 15, 2021
#180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants