-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Streamwise messages not showing on zulip stat card to admin #72
Comments
@isabelcosta Can you please add labels to this issue? |
thank you @codesankalp for helping triage! |
@isabelcosta Ma'am if this issue is not assigned can I take it |
yes @prachi237 🤗 Will assign it to you! |
Thanku ma'am😊 |
@prachi237 Any updates on this issue? Do you need any help or suggestion? |
|
@prachi237 Is your exams over and can you make a PR on this? |
Unassigning @prachi237 due to inactivity. |
if this is still available can i take this? |
Yess it is assigned you here, Do ask if you have any doubts |
Have you setup the backend correctly and is it running? |
@sidharth3000 any updates? |
@sidharth3000 removed your assignment due to a lack of activity. Feel free to claim again, if you want to work on it |
@isabelcosta can you assign this issue to me? |
@msaini0r , @codesankalp assigned this ticket to you :) |
@isabelcosta please merge the pull request. |
if this is still available can i take this? |
Hello @codesankalp, I request you to grant me the access to work on this issue. |
Hey @codesankalp, @isabelcosta i see that the issue is still open and left since a while and so i want to take this up if it is available but before picking it i wanted to ask if the steps mentioned in the HOW TO SOLVE section of the description is up to date coz i see that @msaini28r had followed it and ran into some issues. I wanted to confirm before starting to not to waste your time.
|
Describe the bug
Streamwise messages are not showing on zulip stat to admin because the condition to check streamwise messages is wrong.
We need to delete this condition of checking all streamwise messages by checking the message in the newcomer stream, as it is not required. To test the message
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Streamwise messages do not show up when the student has no message in the newcomer stream.
Screenshots
Desktop (please complete the following information):
How to solve
To solve this issue remove the condition of checking the stream messages by checking message in newcomer stream.
https://github.com/anitab-org/open-source-programs-web/blob/ab18727af5a5e30829e4d07935a218c6d8a02762/src/components/Zulip.js#L39-L51
I have tested by removing it, it is working fine.
Time Required to solve this issue
The text was updated successfully, but these errors were encountered: