added preloader in signup and login page #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaishpra
reviewed
Oct 12, 2021
There was a problem hiding this comment.
Hi @aakankshaagr can you add some screenshots of this feature in your PR description.
Aaishpra
added
the
Status: Needs Review
isabelcosta
reviewed
Oct 13, 2021
| </span> | ||
| </div> | ||
| </Grid.Column> | ||
| Dont have an account{' '} |
There was a problem hiding this comment.
Suggested change
| Dont have an account{' '} | |
| Don't have an account{' '} |
I think it's like this. Did you change this intentionally?
MoKnowOrg
suggested changes
Aug 19, 2022
| @@ -115,11 +119,12 @@ class Login extends Component { | |||
| <> | |||
| <Grid> | |||
| <Grid.Row> | |||
| <div className="preloader"> </div>{' '} | |||
There was a problem hiding this comment.
Please Remove empty string brackets.
Suggested change
| <div className="preloader"> </div>{' '} | |
| <div className="preloader"> </div> |
| <Grid.Column width={5}> | ||
| <div className="login"> | ||
| <span> | ||
| <b>Login</b> | ||
| </span> | ||
| <b> Login </b>{' '} |
There was a problem hiding this comment.
Same over here
Suggested change
| <b> Login </b>{' '} | |
| <b> Login </b> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added spinner preloader while page loads
Fixes #118
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
I have tested it on my local computer
Checklist:
Code/Quality Assurance Only