Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add preloader while completing login or sign up request. #118

Open
nlok5923 opened this issue Mar 9, 2021 · 15 comments · May be fixed by #152
Open

Feat: Add preloader while completing login or sign up request. #118

nlok5923 opened this issue Mar 9, 2021 · 15 comments · May be fixed by #152
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design.

Comments

@nlok5923
Copy link
Contributor

nlok5923 commented Mar 9, 2021

Is your feature request related to a problem? Please describe.

A preloader should be there while login or signup request process.

Describe the solution you'd like

Once user clicked on login there should be a preloader till the time process getting executed in backend and once process completes the preloader should stop and user will be redirected to desired page same will be for signup page.

Describe alternatives you've considered

Adding preloader is the best option i consider.

Additional context

It should have a nice preloader like this one:
image

@nlok5923 nlok5923 changed the title feat: Add preloader while completing login or sign up request. Feat: Add preloader while completing login or sign up request. Mar 9, 2021
@codesankalp codesankalp added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Apr 12, 2021
@aakankshaagr
Copy link

@codesankalp Can I work on this issue?

@Aaishpra Aaishpra removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 22, 2021
@Aaishpra
Copy link
Member

Assigned you @aakankshaagr

@Amishakumari544
Copy link

is any one working on this?? If not I want to work on this.

@aakankshaagr
Copy link

@Amishakumari544 I am working on this. Currently I am redesigning signup. Its almost completed and I have added preloader in that

@Amishakumari544
Copy link

Amishakumari544 commented Jul 7, 2021

But @aakankshaagr you were assigned almost 1month before and you haven't updated it , if you are not doing please update. @Aaishpra

@Aaishpra
Copy link
Member

Aaishpra commented Jul 8, 2021

@Amishakumari544 let's give @aakankshaagr a week to update us with a PR, if she is somehow unable to do so, then you will be assigned here.

@aakankshaagr
Copy link

aakankshaagr commented Jul 10, 2021

@Aaishpra I mistook the repository as bit-in-tech and I implemented preloader there. I was designing signup in that repository. I am trying to paste the same code here but it is not working here so it will take some time. I will make a PR in a day or two. Sorry, for the delay.

@Aaishpra
Copy link
Member

No problem, mistakes can happen take your time just give me updates

@aakankshaagr
Copy link

image
@Aaishpra Is this preloader okay?
I am getting error when I try to push my changes. So I tried to fork repo again , but on forking I get directed to open-source-programs-web.I am not understanding what's happening here? Can you please help me?
image

@codesankalp
Copy link
Member

@aakankshaagr Delete your fork and refork the same repo, and then try to push your code with an updated fork.

According to the error you are pushing your changes to the upstream(anitab-forms) for which you don't have any access i.e. 403.

Create a branch on the fork repo, stage your changes and commit them and then push the new branch.

Preloader review:
I think either you can display the preloader on the whole page or just on the login button area (by hiding login button)
But with the design and everything same, the preloader doesn't look right.

@Aaishpra
Copy link
Member

@aakankshaagr try to do git push -u origin preloader instead of git push --set-upstream origin preloader and if that doesn't work try what Sankalp said above, btw it looks like you are trying to set an upstream and push changes in the same command, this is the command for adding upstream git remote add upstream https://github.com/anitab-org/anitab-forms-web/

@codesankalp
Copy link
Member

Can you update your progress @aakankshaagr ?

@aakankshaagr
Copy link

@codesankalp preloader is there till window loads after that that it's hidden. This page loads extremely quickly so I wasn't able to take screenshots that fastly. So I delayed the timeout for taking a screenshot for giving an update here. I hope size, design, location, and color are okay for the preloader.

Issue in forking:
I tried everything as suggested by both of you but still m getting the same error. I am always using the same command for pushing in any new repo as suggested by the git. It always works.
I tried reforking after deleting but like before instead of anitab-forms-web , fork is taking me to open-source-program-web.

image

I read the readme of both anitab-forms-web and open-source-programs-web to solve this error but that didn't help much. After searching a lot, I realized that our method is failing because I am not getting this repo on forking. I should get git clone https://github.com/aakankshaagr/anitab-forms-web.git
image
I should get this.
Please help me to solve this problem.

@codesankalp
Copy link
Member

@aakankshaagr Name doesn't matter that much, if you want to edit the name you can edit the name from the settings tab.
Try this:

git clone https://github.com/aakankshaagr/open-source-programs-web.git
cd open-source-programs-web
git checkout -b issue-preloader
<do the changes>
git add .
git commit
git push -u origin issue-preloader

Create the PR.

@aakankshaagr aakankshaagr linked a pull request Jul 26, 2021 that will close this issue
7 tasks
@RiShI11-0902
Copy link

Hey is this Issue is still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants