-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add preloader while completing login or sign up request. #118
Comments
@codesankalp Can I work on this issue? |
Assigned you @aakankshaagr |
is any one working on this?? If not I want to work on this. |
@Amishakumari544 I am working on this. Currently I am redesigning signup. Its almost completed and I have added preloader in that |
But @aakankshaagr you were assigned almost 1month before and you haven't updated it , if you are not doing please update. @Aaishpra |
@Amishakumari544 let's give @aakankshaagr a week to update us with a PR, if she is somehow unable to do so, then you will be assigned here. |
@Aaishpra I mistook the repository as bit-in-tech and I implemented preloader there. I was designing signup in that repository. I am trying to paste the same code here but it is not working here so it will take some time. I will make a PR in a day or two. Sorry, for the delay. |
No problem, mistakes can happen take your time just give me updates |
|
@aakankshaagr Delete your fork and refork the same repo, and then try to push your code with an updated fork. According to the error you are pushing your changes to the upstream(anitab-forms) for which you don't have any access i.e. 403. Create a branch on the fork repo, stage your changes and commit them and then push the new branch. Preloader review: |
@aakankshaagr try to do |
Can you update your progress @aakankshaagr ? |
@codesankalp preloader is there till window loads after that that it's hidden. This page loads extremely quickly so I wasn't able to take screenshots that fastly. So I delayed the timeout for taking a screenshot for giving an update here. I hope size, design, location, and color are okay for the preloader. Issue in forking: I read the readme of both anitab-forms-web and open-source-programs-web to solve this error but that didn't help much. After searching a lot, I realized that our method is failing because I am not getting this repo on forking. I should get |
@aakankshaagr Name doesn't matter that much, if you want to edit the name you can edit the name from the settings tab.
Create the PR. |
Hey is this Issue is still open? |
Is your feature request related to a problem? Please describe.
A preloader should be there while login or signup request process.
Describe the solution you'd like
Once user clicked on login there should be a preloader till the time process getting executed in backend and once process completes the preloader should stop and user will be redirected to desired page same will be for signup page.
Describe alternatives you've considered
Adding preloader is the best option i consider.
Additional context
It should have a nice preloader like this one:
The text was updated successfully, but these errors were encountered: