Profile Form doesnt close after submitting

[ruddi10]

Describe the bug

When a user edit or fill the profile even after pressing the submit button the form remains open and I think that creates confusion I would rather suggest that we close the form .

To Reproduce

Steps to reproduce the behavior:

1. Go to dashboard
2. Click on Edit Profile
3. Change some information and click Submit button
4. The form will not close

Expected behavior

I think we should close the form and moreover can use a tost notification once the profile is updated.

Screenshots

Expected-

[ruddi10]

If this issue is fine. Kindly assign it to me @codesankalp @keshakaneria

[codesankalp]

Sure @ruddi10. I am assigning this to you.
Also, one suggestion, If after submission backends respond with an error then don't close the form and display the error inside a message box. Also, don't forget to write a test for this feature.

[ruddi10]

Also should I show a pop-up incase the update is successful or not? @codesankalp

[keshakaneria]

Also should I show a pop-up incase the update is successful or not? @codesankalp

Pop up or a line in red on top above Dashboard text will be fine to let the user know if the form is submitted.

[codesankalp]

Also should I show a pop-up incase the update is successful or not? @codesankalp

Inline Error message box which disappears after some time.
Use Semantic UI.

[ruddi10]

I was asking incase its successful

[keshakaneria]

Also should I show a pop-up incase the update is successful or not? @codesankalp

Pop up or a line in red on top above Dashboard text will be fine to let the user know if the form is submitted.

You can go for this @ruddi10. If you have any queries do let us know.

[codesankalp]

I was asking incase its successful

Same success message box provided in Semantic UI.
And as mentioned by @keshakaneria you can go with your own idea and we will review it in PR.

[ruddi10]

@keshakaneria @codesankalp I have fixed this issue just wanted to know the code formatter used for this repo as I use Prettier and its changing the formatting on save so it might be a problem

[codesankalp]

This will solve after merging of #94.
You can make PR with formatted code.

[ruddi10]

ok thanks

[eleensmathew]

Can I work on this? Can you please guide me since I am new

[jivteshsingh]

If the issue is still there, kindly assign it to me.

[Bishwajitpvt]

If this issue is still active, I can work on it