feat: added configuration options to K-menu #109
Conversation
|
I haven't connected the options to state yet. Just wanted you to review the current flow of the K-Menu to see if the options and language are consistent |
jimezesinachi
requested review from
berendsliedrecht,
janrtvld and
TimoGlastra
There was a problem hiding this comment.
left some nits, but looks good overall. Only thing is that there are some options that can't be configured yet (e.g. only present proof v1 is in this release of AFJ rest and there's only one ledger to choose from), however we can just add an options menu with one choice for now I guess
|
Looks good! I would change the wording around a bit as the options aren't preferred i.e. i would change Could you also add the 'shortcut' property so you can easily navigate using your keyboard? |
Signed-off-by: Jim Ezesinachi <[email protected]>
Signed-off-by: Jim Ezesinachi <[email protected]>
Signed-off-by: Jim Ezesinachi <[email protected]>
build: expose /agent endpoint for monitoring
Signed-off-by: Jim Ezesinachi <[email protected]>
…paktech/animo-demo into feat/add-configuration-screen
|
@janrtvld the createInvitation now works, but there is other issue with offerCredential. Looking at it right now |
Signed-off-by: Jim Ezesinachi <[email protected]>
|
Fixed use of configuration state, but there is anoher issue with the findByOutOfBandId which seems to be recursively calling but returning no payload |
jimezesinachi
requested review from
janrtvld
and removed request for
berendsliedrecht
|
Great work! Can you also process some of the details Timo has described in #94 ? |
Co-authored-by: Jan <[email protected]>
Co-authored-by: Jan <[email protected]>
Signed-off-by: Jim Ezesinachi <[email protected]>
Signed-off-by: Jim Ezesinachi <[email protected]>
Signed-off-by: Jim Ezesinachi <[email protected]>
…eset logic to config menu options Signed-off-by: Jim Ezesinachi <[email protected]>
…ding page Signed-off-by: Jim Ezesinachi <[email protected]>
Co-authored-by: Jan <[email protected]>
… unused items from K-menu Signed-off-by: Jim Ezesinachi <[email protected]>
…paktech/animo-demo into feat/add-configuration-screen
Co-authored-by: Timo Glastra <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
…tems from K-menu Signed-off-by: Jim Ezesinachi <[email protected]>
Signed-off-by: Jim Ezesinachi <[email protected]>
…gacy Signed-off-by: Jim Ezesinachi <[email protected]>
There was a problem hiding this comment.
Can't really comment on the cypress tests (@janrtvld can), but really excited about this. Great work!
|
Thanks @TimoGlastra |
There was a problem hiding this comment.
Almost there! Few comments but overall looks good!
Could you also create an option in the CMD+K menu that completely resets the demo (demo/RESET)? So we have 2 options of resetting: resetting only the state and resetting the whole demo including the configuration options.
…5000ms & feat: added resetState to K-menu and Onboarding page Signed-off-by: Jim Ezesinachi <[email protected]>
Co-authored-by: Jan <[email protected]>
Co-authored-by: Jan <[email protected]>
Co-authored-by: Jan <[email protected]>
No description provided.