Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define enums for for status values, wheel-corners etc #2

Open
advisoft opened this issue Jul 20, 2021 · 7 comments
Open

Define enums for for status values, wheel-corners etc #2

advisoft opened this issue Jul 20, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@advisoft
Copy link
Contributor

What do you think about that?

I am doing that locally on my end, but I can start making pull requests for them if you are interested?

e.g.

const (
	rearLeft = iota
	rearRight
	frontLeft
	frontRight
)

then

.BrakesTemperature[frontRight]

Maybe in the packets package?

@anilmisirlioglu
Copy link
Owner

Yeah, seems logical.

I think the code will be more human-readable if we write the values ​​by hand instead of typing them as iota.

@advisoft
Copy link
Contributor Author

Yep not worried, just whatever you want.

Will make a pull request in the next few days.

Hey another thing, there is no way to terminate after calling run as far as I can tell. I can sort that out too if you want?

@anilmisirlioglu
Copy link
Owner

anilmisirlioglu commented Jul 20, 2021

Sounds good, If you have a good solution that would be nice. I'll be waiting for your PR request.

also after stabilizing a bit more, I'm planning to start implementing the 2021 UDP specs.

@anilmisirlioglu
Copy link
Owner

Hi @advisoft, are you still considering doing this issue?

@advisoft
Copy link
Contributor Author

Yep, next couple of days.

@anilmisirlioglu anilmisirlioglu added the enhancement New feature or request label Aug 3, 2021
@advisoft
Copy link
Contributor Author

advisoft commented Aug 4, 2021

Been off work sick, got quite a backlog to get thru before I can progress on this.

@anilmisirlioglu
Copy link
Owner

anilmisirlioglu commented Aug 4, 2021

no problem ^^

I added a little something about it: 67ea6d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants