Skip to content

Commit 872ab8f

Browse files
committed
fix(github-actions): allow for mergeability checks before a pr is marked as merge ready (#2899)
The merge ready label should be applied when we know something is ready for merge, it does not make sense that the check only occurs once the label is applied as it should provide information about if it is merge ready. PR Close #2899
1 parent 7b901c7 commit 872ab8f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/local-actions/branch-manager/lib/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ async function main() {
8181
pr,
8282
createPullRequestValidationConfig({
8383
assertSignedCla: true,
84-
assertMergeReady: true,
84+
assertMergeReady: false,
8585
assertPending: false,
8686
assertChangesAllowForTargetLabel: false,
8787
assertPassingCi: false,

.github/local-actions/branch-manager/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64535,7 +64535,7 @@ async function main() {
6453564535
await cloneRepoIntoTmpLocation({ owner, repo });
6453664536
const pullRequest = await loadAndValidatePullRequest({ git, config }, pr, createPullRequestValidationConfig({
6453764537
assertSignedCla: true,
64538-
assertMergeReady: true,
64538+
assertMergeReady: false,
6453964539
assertPending: false,
6454064540
assertChangesAllowForTargetLabel: false,
6454164541
assertPassingCi: false,

0 commit comments

Comments
 (0)