Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(multiple): switch the CDK to the inject function #29718

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

crisbeto
Copy link
Member

Reworks all of the CDK directives and injectables to use the inject function instead of constructor-based injection. All the constructors have a backwards-compatible signature for the apps that may be extending them.

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Sep 11, 2024
@crisbeto crisbeto force-pushed the cdk-inject branch 2 times, most recently from 7ba3c05 to 1fffc66 Compare September 11, 2024 10:21
@crisbeto crisbeto marked this pull request as ready for review September 11, 2024 10:27
@crisbeto crisbeto requested a review from a team as a code owner September 11, 2024 10:27
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team September 11, 2024 10:27
@crisbeto crisbeto force-pushed the cdk-inject branch 3 times, most recently from 8f62f30 to 669cd7f Compare September 12, 2024 11:38
Reworks all of the CDK directives and injectables to use the `inject` function instead of constructor-based injection. All the constructors have a backwards-compatible signature for the apps that may be extending them.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 12, 2024
@crisbeto crisbeto merged commit b8ec0a6 into angular:main Sep 12, 2024
21 of 23 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants