Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-ms-high-constrast is in the process of being deprecated #29222

Closed
1 task
happybuddha opened this issue Jun 10, 2024 · 4 comments
Closed
1 task

-ms-high-constrast is in the process of being deprecated #29222

happybuddha opened this issue Jun 10, 2024 · 4 comments

Comments

@happybuddha
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

When using Material Dialog, in edge, in the console, I get a
[Deprecation] -ms-high-constrast is in the process of being deprecated. Please see <URL> for tips on updating to the new Forced Colors Mode standard.

Using the Dialog as :

<h2 mat-dialog-title>{{data.title}}</h2>

<mat-dialog-content>
    <p>{{data.message}}</p>
</mat-dialog-content>

<mat-dialog-actions [align]="'end'">  
    <button mat-raised-button cdkFocusInitial mat-dialog-close [mat-dialog-close]="false">
        {{data.cancelCaption}}
    </button>
    <button mat-raised-button color="primary" [mat-dialog-close]="true">
        {{data.confirmCaption}}
    </button>
</mat-dialog-actions>

I also discussed this on stack overflow : https://stackoverflow.com/questions/78595309/how-to-address-the-ms-high-constrast-deprecation-message-in-edge/78601405

Reproduction

StackBlitz link:
Steps to reproduce:
1.
2.

Expected Behavior

To not see the deprecated warnings in Edge developer console

Actual Behavior

image

Environment

  • Angular:
  • CDK/Material:
  • Browser(s):
  • Operating System (e.g. Windows, macOS, Ubuntu):
@happybuddha happybuddha added the needs triage This issue needs to be triaged by the team label Jun 10, 2024
@crisbeto
Copy link
Member

I don't see any references to it in our repository. Does the warning say where the usage is coming from?

@crisbeto crisbeto added needs: clarification The issue does not contain enough information for the team to determine if it is a real bug area: cdk/a11y and removed needs triage This issue needs to be triaged by the team labels Jun 17, 2024
@happybuddha
Copy link
Author

I don't see any references to it in our repository. Does the warning say where the usage is coming from?

It points to the code in my angular project. When I right click on the dialog box -> inspect -> Ctrl+f and search for high-contrast I see two occurrences, one of which this issue is about:
image

If this is not what you are looking for, please give me steps to how I can find out the information you are looking for.

@crisbeto
Copy link
Member

Ah, I see. We don't have much control over those styles at the moment, but we're in the process of moving away from them. The dialog specifically was already moved in #29068.

@crisbeto crisbeto removed the needs: clarification The issue does not contain enough information for the team to determine if it is a real bug label Jun 19, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants