Skip to content

Commit 7443bb5

Browse files
EduardF97EduardF1
EduardF97
authored and
EduardF1
committed
fix(material/list): use valid ChangeDetectionStrategy.Default in test ChangeDetectionStrategy.Eager does not exist in Angular's API. Using Default (the implicit default) instead.
1 parent 3505aee commit 7443bb5

3 files changed

Lines changed: 37 additions & 37 deletions

File tree

‎src/material/list/list.spec.ts‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ class BaseTestList {
417417
</a>
418418
</mat-list>`,
419419
imports: [MatListModule],
420-
changeDetection: ChangeDetectionStrategy.Eager,
420+
changeDetection: ChangeDetectionStrategy.Default,
421421
})
422422
class ListWithOneAnchorItem extends BaseTestList {
423423
// This needs to be declared directly on the class; if declared on the BaseTestList superclass,
@@ -433,7 +433,7 @@ class ListWithOneAnchorItem extends BaseTestList {
433433
</a>
434434
</mat-nav-list>`,
435435
imports: [MatListModule],
436-
changeDetection: ChangeDetectionStrategy.Eager,
436+
changeDetection: ChangeDetectionStrategy.Default,
437437
})
438438
class NavListWithOneAnchorItem extends BaseTestList {
439439
@ViewChildren(MatListItem) listItems!: QueryList<MatListItem>;
@@ -452,7 +452,7 @@ class NavListWithOneAnchorItem extends BaseTestList {
452452
}
453453
</mat-nav-list>`,
454454
imports: [MatListModule],
455-
changeDetection: ChangeDetectionStrategy.Eager,
455+
changeDetection: ChangeDetectionStrategy.Default,
456456
})
457457
class NavListWithActivatedItem extends BaseTestList {
458458
@ViewChildren(MatListItem) listItems!: QueryList<MatListItem>;
@@ -471,7 +471,7 @@ class NavListWithActivatedItem extends BaseTestList {
471471
</button>
472472
</mat-action-list>`,
473473
imports: [MatListModule],
474-
changeDetection: ChangeDetectionStrategy.Eager,
474+
changeDetection: ChangeDetectionStrategy.Default,
475475
})
476476
class ActionListWithoutType extends BaseTestList {
477477
@ViewChildren(MatListItem) listItems!: QueryList<MatListItem>;
@@ -487,7 +487,7 @@ class ActionListWithoutType extends BaseTestList {
487487
</button>
488488
</mat-action-list>`,
489489
imports: [MatListModule],
490-
changeDetection: ChangeDetectionStrategy.Eager,
490+
changeDetection: ChangeDetectionStrategy.Default,
491491
})
492492
class ActionListWithType extends BaseTestList {
493493
@ViewChildren(MatListItem) listItems!: QueryList<MatListItem>;
@@ -501,7 +501,7 @@ class ActionListWithType extends BaseTestList {
501501
}
502502
</mat-action-list>`,
503503
imports: [MatListModule],
504-
changeDetection: ChangeDetectionStrategy.Eager,
504+
changeDetection: ChangeDetectionStrategy.Default,
505505
})
506506
class ActionListWithDisabledList extends BaseTestList {
507507
disableList = true;
@@ -515,7 +515,7 @@ class ActionListWithDisabledList extends BaseTestList {
515515
</button>
516516
</mat-action-list>`,
517517
imports: [MatListModule],
518-
changeDetection: ChangeDetectionStrategy.Eager,
518+
changeDetection: ChangeDetectionStrategy.Default,
519519
})
520520
class ActionListWithDisabledItem extends BaseTestList {
521521
@ViewChild(MatListItem) buttonItem!: MatListItem;
@@ -530,7 +530,7 @@ class ActionListWithDisabledItem extends BaseTestList {
530530
</mat-list-item>
531531
</mat-list>`,
532532
imports: [MatListModule],
533-
changeDetection: ChangeDetectionStrategy.Eager,
533+
changeDetection: ChangeDetectionStrategy.Default,
534534
})
535535
class ListWithOneItem extends BaseTestList {}
536536

@@ -546,7 +546,7 @@ class ListWithOneItem extends BaseTestList {}
546546
}
547547
</mat-list>`,
548548
imports: [MatListModule],
549-
changeDetection: ChangeDetectionStrategy.Eager,
549+
changeDetection: ChangeDetectionStrategy.Default,
550550
})
551551
class ListWithTwoLineItem extends BaseTestList {}
552552

@@ -562,7 +562,7 @@ class ListWithTwoLineItem extends BaseTestList {}
562562
}
563563
</mat-list>`,
564564
imports: [MatListModule],
565-
changeDetection: ChangeDetectionStrategy.Eager,
565+
changeDetection: ChangeDetectionStrategy.Default,
566566
})
567567
class ListWithThreeLineItem extends BaseTestList {}
568568

@@ -578,7 +578,7 @@ class ListWithThreeLineItem extends BaseTestList {}
578578
</mat-list-item>
579579
</mat-list>`,
580580
imports: [MatListModule],
581-
changeDetection: ChangeDetectionStrategy.Eager,
581+
changeDetection: ChangeDetectionStrategy.Default,
582582
})
583583
class ListWithAvatar extends BaseTestList {}
584584

@@ -593,7 +593,7 @@ class ListWithAvatar extends BaseTestList {}
593593
}
594594
</mat-list>`,
595595
imports: [MatListModule],
596-
changeDetection: ChangeDetectionStrategy.Eager,
596+
changeDetection: ChangeDetectionStrategy.Default,
597597
})
598598
class ListWithItemWithCssClass extends BaseTestList {}
599599

@@ -611,7 +611,7 @@ class ListWithItemWithCssClass extends BaseTestList {}
611611
}
612612
</mat-list>`,
613613
imports: [MatListModule],
614-
changeDetection: ChangeDetectionStrategy.Eager,
614+
changeDetection: ChangeDetectionStrategy.Default,
615615
})
616616
class ListWithDynamicNumberOfLines extends BaseTestList {}
617617

@@ -623,7 +623,7 @@ class ListWithDynamicNumberOfLines extends BaseTestList {}
623623
}
624624
</mat-list>`,
625625
imports: [MatListModule],
626-
changeDetection: ChangeDetectionStrategy.Eager,
626+
changeDetection: ChangeDetectionStrategy.Default,
627627
})
628628
class ListWithMultipleItems extends BaseTestList {}
629629

@@ -635,7 +635,7 @@ class ListWithMultipleItems extends BaseTestList {}
635635
<mat-list-item>Three</mat-list-item>
636636
</mat-list>`,
637637
imports: [MatListModule],
638-
changeDetection: ChangeDetectionStrategy.Eager,
638+
changeDetection: ChangeDetectionStrategy.Default,
639639
})
640640
class ListWithDisabledItems {
641641
firstItemDisabled = false;
@@ -645,6 +645,6 @@ class ListWithDisabledItems {
645645
@Component({
646646
template: `<mat-list-item></mat-list-item>`,
647647
imports: [MatListModule],
648-
changeDetection: ChangeDetectionStrategy.Eager,
648+
changeDetection: ChangeDetectionStrategy.Default,
649649
})
650650
class StandaloneListItem {}

‎src/material/list/selection-list.spec.ts‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,7 @@ describe('MatSelectionList with forms', () => {
17101710
}
17111711
</mat-selection-list>`,
17121712
imports: [MatListModule],
1713-
changeDetection: ChangeDetectionStrategy.Eager,
1713+
changeDetection: ChangeDetectionStrategy.Default,
17141714
})
17151715
class SelectionListWithListOptions {
17161716
showLastOption = true;
@@ -1739,7 +1739,7 @@ class SelectionListWithListOptions {
17391739
</mat-list-option>
17401740
</mat-selection-list>`,
17411741
imports: [MatListModule],
1742-
changeDetection: ChangeDetectionStrategy.Eager,
1742+
changeDetection: ChangeDetectionStrategy.Default,
17431743
})
17441744
class SelectionListWithCheckboxPositionAfter {}
17451745

@@ -1760,7 +1760,7 @@ class SelectionListWithCheckboxPositionAfter {}
17601760
</mat-list-option>
17611761
</mat-selection-list>`,
17621762
imports: [MatListModule],
1763-
changeDetection: ChangeDetectionStrategy.Eager,
1763+
changeDetection: ChangeDetectionStrategy.Default,
17641764
})
17651765
class SelectionListWithListDisabled {
17661766
disabled: boolean = true;
@@ -1772,7 +1772,7 @@ class SelectionListWithListDisabled {
17721772
<mat-list-option>Inbox</mat-list-option>
17731773
</mat-selection-list>`,
17741774
imports: [MatListModule],
1775-
changeDetection: ChangeDetectionStrategy.Eager,
1775+
changeDetection: ChangeDetectionStrategy.Default,
17761776
})
17771777
class DisabledSingleSelectionList {}
17781778

@@ -1783,7 +1783,7 @@ class DisabledSingleSelectionList {}
17831783
</mat-selection-list>
17841784
`,
17851785
imports: [MatListModule],
1786-
changeDetection: ChangeDetectionStrategy.Eager,
1786+
changeDetection: ChangeDetectionStrategy.Default,
17871787
})
17881788
class SelectionListWithDisabledOption {
17891789
disableItem: boolean = false;
@@ -1798,7 +1798,7 @@ class SelectionListWithDisabledOption {
17981798
<mat-list-option>Not selected - Item #4</mat-list-option>
17991799
</mat-selection-list>`,
18001800
imports: [MatListModule],
1801-
changeDetection: ChangeDetectionStrategy.Eager,
1801+
changeDetection: ChangeDetectionStrategy.Default,
18021802
})
18031803
class SelectionListWithSelectedOption {}
18041804

@@ -1809,7 +1809,7 @@ class SelectionListWithSelectedOption {}
18091809
<mat-list-option [selected]="true">Pre-selected - Item #2</mat-list-option>
18101810
</mat-selection-list>`,
18111811
imports: [MatListModule],
1812-
changeDetection: ChangeDetectionStrategy.Eager,
1812+
changeDetection: ChangeDetectionStrategy.Default,
18131813
})
18141814
class SingleSelectionListWithSelectedOption {}
18151815

@@ -1819,7 +1819,7 @@ class SingleSelectionListWithSelectedOption {}
18191819
<mat-list-option [selected]="true" [value]="itemValue">Item</mat-list-option>
18201820
</mat-selection-list>`,
18211821
imports: [MatListModule],
1822-
changeDetection: ChangeDetectionStrategy.Eager,
1822+
changeDetection: ChangeDetectionStrategy.Default,
18231823
})
18241824
class SelectionListWithSelectedOptionAndValue {
18251825
itemValue = 'item1';
@@ -1836,7 +1836,7 @@ class SelectionListWithSelectedOptionAndValue {
18361836
}
18371837
</mat-selection-list>`,
18381838
imports: [MatListModule, FormsModule, ReactiveFormsModule],
1839-
changeDetection: ChangeDetectionStrategy.Eager,
1839+
changeDetection: ChangeDetectionStrategy.Default,
18401840
})
18411841
class SelectionListWithModel {
18421842
modelChangeSpy = jasmine.createSpy('model change spy');
@@ -1859,7 +1859,7 @@ class SelectionListWithModel {
18591859
}
18601860
`,
18611861
imports: [MatListModule, FormsModule, ReactiveFormsModule],
1862-
changeDetection: ChangeDetectionStrategy.Eager,
1862+
changeDetection: ChangeDetectionStrategy.Default,
18631863
})
18641864
class SelectionListWithFormControl {
18651865
formControl = new FormControl([] as string[]);
@@ -1874,7 +1874,7 @@ class SelectionListWithFormControl {
18741874
<mat-list-option value="opt2" selected>Option 2</mat-list-option>
18751875
</mat-selection-list>`,
18761876
imports: [MatListModule, FormsModule, ReactiveFormsModule],
1877-
changeDetection: ChangeDetectionStrategy.Eager,
1877+
changeDetection: ChangeDetectionStrategy.Default,
18781878
})
18791879
class SelectionListWithPreselectedOption {
18801880
selectedOptions!: string[];
@@ -1887,7 +1887,7 @@ class SelectionListWithPreselectedOption {
18871887
<mat-list-option value="opt2" selected>Option 2</mat-list-option>
18881888
</mat-selection-list>`,
18891889
imports: [MatListModule, FormsModule, ReactiveFormsModule],
1890-
changeDetection: ChangeDetectionStrategy.Eager,
1890+
changeDetection: ChangeDetectionStrategy.Default,
18911891
})
18921892
class SelectionListWithPreselectedOptionAndModel {
18931893
selectedOptions = ['opt1'];
@@ -1916,7 +1916,7 @@ class SelectionListWithPreselectedFormControlOnPush {
19161916
}
19171917
</mat-selection-list>`,
19181918
imports: [MatListModule, FormsModule, ReactiveFormsModule],
1919-
changeDetection: ChangeDetectionStrategy.Eager,
1919+
changeDetection: ChangeDetectionStrategy.Default,
19201920
})
19211921
class SelectionListWithCustomComparator {
19221922
@ViewChildren(MatListOption) optionInstances!: QueryList<MatListOption>;
@@ -1939,7 +1939,7 @@ class SelectionListWithCustomComparator {
19391939
</mat-selection-list>
19401940
`,
19411941
imports: [MatListModule],
1942-
changeDetection: ChangeDetectionStrategy.Eager,
1942+
changeDetection: ChangeDetectionStrategy.Default,
19431943
})
19441944
class SelectionListWithAvatar {
19451945
togglePosition!: MatListOptionTogglePosition;
@@ -1955,7 +1955,7 @@ class SelectionListWithAvatar {
19551955
</mat-selection-list>
19561956
`,
19571957
imports: [MatListModule],
1958-
changeDetection: ChangeDetectionStrategy.Eager,
1958+
changeDetection: ChangeDetectionStrategy.Default,
19591959
})
19601960
class SelectionListWithIcon {
19611961
togglePosition!: MatListOptionTogglePosition;
@@ -1971,7 +1971,7 @@ class SelectionListWithIcon {
19711971
}
19721972
</mat-selection-list>`,
19731973
imports: [MatListModule],
1974-
changeDetection: ChangeDetectionStrategy.Eager,
1974+
changeDetection: ChangeDetectionStrategy.Default,
19751975
})
19761976
class SelectionListWithIndirectChildOptions {
19771977
@ViewChildren(MatListOption) optionInstances!: QueryList<MatListOption>;
@@ -1984,7 +1984,7 @@ class SelectionListWithIndirectChildOptions {
19841984
</mat-selection-list>
19851985
`,
19861986
imports: [MatListModule],
1987-
changeDetection: ChangeDetectionStrategy.Eager,
1987+
changeDetection: ChangeDetectionStrategy.Default,
19881988
})
19891989
class ListOptionWithTwoWayBinding {
19901990
selected = false;

‎src/material/list/testing/list-harness.spec.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ describe('MatSelectionListHarness', () => {
526526
<mat-list class="test-empty"></mat-list>
527527
`,
528528
imports: [MatListModule],
529-
changeDetection: ChangeDetectionStrategy.Eager,
529+
changeDetection: ChangeDetectionStrategy.Default,
530530
})
531531
class ListHarnessTest {
532532
disableThirdItem = signal(false);
@@ -567,7 +567,7 @@ class ListHarnessTest {
567567
<mat-action-list class="test-empty"></mat-action-list>
568568
`,
569569
imports: [MatListModule],
570-
changeDetection: ChangeDetectionStrategy.Eager,
570+
changeDetection: ChangeDetectionStrategy.Default,
571571
})
572572
class ActionListHarnessTest {
573573
lastClicked!: string;
@@ -610,7 +610,7 @@ class ActionListHarnessTest {
610610
<mat-nav-list class="test-empty"></mat-nav-list>
611611
`,
612612
imports: [MatListModule],
613-
changeDetection: ChangeDetectionStrategy.Eager,
613+
changeDetection: ChangeDetectionStrategy.Default,
614614
})
615615
class NavListHarnessTest {
616616
lastClicked!: string;
@@ -654,7 +654,7 @@ class NavListHarnessTest {
654654
<mat-selection-list class="test-empty" disabled></mat-selection-list>
655655
`,
656656
imports: [MatListModule],
657-
changeDetection: ChangeDetectionStrategy.Eager,
657+
changeDetection: ChangeDetectionStrategy.Default,
658658
})
659659
class SelectionListHarnessTest {
660660
disableThirdItem = signal(false);

0 commit comments

Comments
 (0)