Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test test_techniques.test_indirectcfi fails frequently in CI #54

Open
twizmwazin opened this issue Jun 24, 2024 · 1 comment
Open

Test test_techniques.test_indirectcfi fails frequently in CI #54

twizmwazin opened this issue Jun 24, 2024 · 1 comment
Labels

Comments

@twizmwazin
Copy link
Member

Description

This test fails frequently in CI. The immediate cause is a timeout from Z3. This should be investigated and fixed if possible, or the test should be rewritten to avoid this issue.

Steps to reproduce the bug

It is difficult to do so as the failure is inconsistent and only usually appears on low-performance systems. Most developers looking at this will likely be using a device too fast to reliably reproduce it.

Environment

No response

Additional context

No response

@twizmwazin twizmwazin added the bug label Jun 24, 2024
@twizmwazin
Copy link
Member Author

Echoing @rhelmot in #55 "I'm fine with this diff, but I would like to register the concern that the problem isn't with z3, but rather that patcherex is generating unsolvable constraints. Just so that anyone who sees this in the future doesn't think there was consensus that this was a good fix."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant