Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify_same_elements doesn't throw a ValueError if either list 1 or list 2 have a length of 0 (not both) #50

Open
alex-l-kong opened this issue Dec 5, 2024 · 0 comments
Open

verify_same_elements doesn't throw a ValueError if either list 1 or list 2 have a length of 0 (not both) #50

alex-l-kong opened this issue Dec 5, 2024 · 0 comments
Assignees
@alex-l-kong
Labels
bug Something isn't working

Comments

@alex-l-kong
Copy link
Contributor

Describe the bug

At https://github.com/angelolab/alpineer/blob/main/src/alpineer/misc_utils.py#L176-L177 (ex. list_one_cast = [] and list_two_cast = [1, 2, 3]), this statement returns False, which is incorrect, because it won't correctly inform the user that the input was invalid.

Expected behavior

Instead, a ValueError should be raised with an informative message.
@alex-l-kong alex-l-kong added the bug Something isn't working label Dec 5, 2024
@alex-l-kong alex-l-kong self-assigned this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-l-kong alex-l-kong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex-l-kong