From 2a6f6546d9ed1770971ee0713f5c45d51d2b3e26 Mon Sep 17 00:00:00 2001 From: Tobe O Date: Sun, 28 Apr 2019 13:09:44 -0400 Subject: [PATCH] Apply pedantic --- analysis_options.yaml | 1 + lib/src/options.dart | 10 +++++----- lib/src/runner.dart | 4 ++-- pubspec.yaml | 4 +++- 4 files changed, 11 insertions(+), 8 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index eae1e42..c230cee 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,3 +1,4 @@ +include: package:pedantic/analysis_options.yaml analyzer: strong-mode: implicit-casts: false \ No newline at end of file diff --git a/lib/src/options.dart b/lib/src/options.dart index 9fefe06..798443f 100644 --- a/lib/src/options.dart +++ b/lib/src/options.dart @@ -25,11 +25,11 @@ class RunnerOptions { final bool useZone, respawn; RunnerOptions( - {this.hostname: '127.0.0.1', - this.port: 3000, - this.concurrency: 1, - this.useZone: false, - this.respawn: true}); + {this.hostname = '127.0.0.1', + this.port = 3000, + this.concurrency = 1, + this.useZone = false, + this.respawn = true}); factory RunnerOptions.fromArgResults(ArgResults argResults) { return new RunnerOptions( diff --git a/lib/src/runner.dart b/lib/src/runner.dart index 98691fc..e96f7b3 100644 --- a/lib/src/runner.dart +++ b/lib/src/runner.dart @@ -23,7 +23,7 @@ class Runner { final Reflector reflector; Runner(this.name, this.configureServer, - {this.reflector: const EmptyReflector()}); + {this.reflector = const EmptyReflector()}); static const String asciiArt = ''' ____________ ________________________ @@ -168,7 +168,7 @@ _ ___ | /| / / /_/ / _ /___ _ /___ stderr..writeln('fatal error: $e'); exitCode = 1; } finally { - server?.close(); + await server?.close(); } } diff --git a/pubspec.yaml b/pubspec.yaml index 3078814..b2133e6 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: angel_production -version: 1.0.0-alpha.1 +version: 1.0.0 description: Helpers for concurrency, message-passing, rotating loggers, and other production functionality in Angel. author: Tobe O homepage: https://github.com/angel-dart/production @@ -12,3 +12,5 @@ dependencies: io: ^0.3.2 logging: ^0.11.3 pub_sub: ^2.0.0 +dev_dependencies: + pedantic: ^1.0.0