Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] default language keys when missing in a split_export_files #60

Open
Cyrille37 opened this issue Jan 18, 2019 · 4 comments
Open

Comments

@Cyrille37
Copy link

Cyrille37 commented Jan 18, 2019

Hi and thanks a lot for this great and useful package.

It could be nice to have an option that make generation of split_export_files merging default language keys when they are missing in a language file.

For example with those languages keys in resources/langs :

  • en [default]
    • foo
    • bar
  • fr
    • foo

we could navigate in language "fr" and displaying the "en [default]" value in place of the key path.

Also it make Javascript translation works like the Php Laravel side with a default language value when a language missing a key.

I Hope to be clear enough ... I'm not sure :-)

@Cyrille37 Cyrille37 changed the title default language keys when missing in a split_export_files [feature] default language keys when missing in a split_export_files Jan 18, 2019
@andywer
Copy link
Owner

andywer commented Jan 19, 2019

Interesting point. Thanks for sharing, @Cyrille37!

Anyone else have an opinion on that?

@ackalhan
Copy link

ackalhan commented Feb 1, 2019

I'am glad using this package, And we also finding a solution for this in our project. Really appreciate if you guys can add this ASAP. Thanks

@andywer
Copy link
Owner

andywer commented Feb 2, 2019

This package is not under active development anymore, at least not by me.

Feel free to submit a PR implementing the feature you need, though. I will handle the PR, we just need some community work here 😉

@ackalhan
Copy link

ackalhan commented Feb 5, 2019

@andywer made a pull with a change check that out thanks.
#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants