Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long translations keys (translation strings as keys) support? #45

Open
carestad opened this issue Apr 14, 2018 · 8 comments
Open

Long translations keys (translation strings as keys) support? #45

carestad opened this issue Apr 14, 2018 · 8 comments

Comments

@carestad
Copy link
Contributor

I can't seem to make the .json files (as explained here) work with js-localization, and especially the :export command.

Is this supported?

@andywer
Copy link
Owner

andywer commented Apr 14, 2018

Probably a duplicate of #40. Sorry, but this repo really needs a substitute maintainer 😕

@andywer
Copy link
Owner

andywer commented Apr 14, 2018

Feel free to re-open if it's not due to the lacking Laravel 5.5 support.

@andywer andywer closed this as completed Apr 14, 2018
@carestad
Copy link
Contributor Author

carestad commented Apr 14, 2018

No I believe the Laravel 5.5 support was fixed in #40 with PR #41? I am running Laravel 5.5 and have no problems with either commands at least 😄

I think this would be a separate issue where one would have to include the language specific .json files in the resources/lang/ directory, if they exist, into the cache (for the :refresh command) and messages.js (for the :export command)?

@andywer andywer reopened this Apr 15, 2018
@carestad
Copy link
Contributor Author

I have a working implementation of this as well, and should be able to provide a PR for this soon.

@SamuelNitsche
Copy link

Sorry for bumping up this old issue..

@carestad Do you still have the working implementation for translation strings?

@carestad
Copy link
Contributor Author

No, I'm afraid not 😞

The needs for my project changed and it was no longer necessary.

Plus, if you use full string translations, you kind of already have the JSON for them I suppose, so re-doing the implementation or writing a proxy that reads the right ones souldn't be too difficult.

@SamuelNitsche
Copy link

Yeah, I already found kind of a solution. Thank you!

@GENL
Copy link

GENL commented Mar 13, 2021

Now Matice is used: https://github.com/GENL/matice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants