Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyPage 0.8.3 and IE7 #5

Open
tinytina opened this issue May 13, 2009 · 5 comments
Open

PolyPage 0.8.3 and IE7 #5

tinytina opened this issue May 13, 2009 · 5 comments

Comments

@tinytina
Copy link

Just downloaded 0.8.3 and tried to run the demo you provided. Anytime I click on one of the triggers at the top, it simply adds "#pp_toggle_admin" to the url. Works in FF3, Opera 9, Chrome, but not IE No surprises there, I guess, but the demo you have posted at http://code.new-bamboo.co.uk/polypage/ does work...

@andykent
Copy link
Owner

Eeek! Thanks, I'll take a look into this, this week.

@tinytina
Copy link
Author

Any updates on this working with IE7? It does work with IE8 (again, no surprises that IE is wonky), but not IE7.

@sionnnn
Copy link

sionnnn commented Nov 4, 2009

this is an issue with triggerEventFromHash in events.polypage.jquery.js

replace line 42
if(hash.search(/^#pp_/)==-1) return false;
var hash = hash.replace(/^#pp_/,'');

with
if(hash.search(/#pp_/)==-1) return false;
var dummyhash = hash.split("#pp_");
var hash = dummyhash[dummyhash.length - 1];

works for me

@smt
Copy link

smt commented Jan 25, 2010

sionnnn's change works for me. Thanks sionnnn!

@maban
Copy link

maban commented Apr 25, 2012

Just in case anyone else comes across the same issue, I think there should be an underscore after all instances of #pp in sionnnn's code. Github comments seem to strip them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants