Reading from a closed body in case of a network error during body read

[markvai]

What happened?

We got this error when using the client:

unexpected EOF: file already closed

What did you expect to happen?

We don't expect to see file already closed errors.

How can we reproduce it (as minimally and precisely as possible)?

This is sporadic and can happen when reading from the http response body after a valid response status was received.

The root cause here it's possible that an error is returned while reading the response body, like here:

go-jira/cloud/jira.go

Lines 249 to 250 in 50d59fe

	defer httpResp.Body.Close()
	err = json.NewDecoder(httpResp.Body).Decode(v)

So while decoding there is a network error and the read fails, not the body is closed on defer.

Than the error is passed to:

go-jira/cloud/issue.go

Line 1084 in 50d59fe

err = NewJiraError(resp, err)

And there, it is expected that the body was not closed/read already, so it tries to read again from the body:

go-jira/cloud/error.go

Lines 25 to 26 in 50d59fe

	defer resp.Body.Close()
	body, err := io.ReadAll(resp.Body)

As a result we get a confusing error.