You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I'm updating Jiralert, which uses go-jira and the PR is getting flagged by CI due to:
cmd/jiralert/main.go:118:4: SA1019: client.Authentication.SetBasicAuth is deprecated: Use BasicAuthTransport instead (staticcheck)
I'm under the impression that Authentication.SetBasicAuth is needed if using a non-standard transport - in this case, I've added support for client certificates but would equally apply to specifying a custom CA.
Am I mistaken? If not, should the deprecation flag be removed from Authentication.SetBasicAuth, with just a note about BasicAuthTransport?
Describe the solution you'd like
Currently, I just need to ignore the deprecation warnings from the CI system.
Describe alternatives you've considered
Perhaps I'm missing some other method of doing Basic Auth with a non-standard transport.
The text was updated successfully, but these errors were encountered:
Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.
I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.
However, there is news: We are kicking off v2 of this library 🚀
To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489
The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your issue + you like to sponsor it, please contact me.
What does this mean for my issue?
We will work on this issue indirectly.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.
Final words
Thanks for using this library.
If there is anything else you would like to tell us, let us know!
Is your feature request related to a problem? Please describe.
I'm updating Jiralert, which uses go-jira and the PR is getting flagged by CI due to:
cmd/jiralert/main.go:118:4: SA1019: client.Authentication.SetBasicAuth is deprecated: Use BasicAuthTransport instead (staticcheck)
I'm under the impression that Authentication.SetBasicAuth is needed if using a non-standard transport - in this case, I've added support for client certificates but would equally apply to specifying a custom CA.
Am I mistaken? If not, should the deprecation flag be removed from Authentication.SetBasicAuth, with just a note about BasicAuthTransport?
Describe the solution you'd like
Currently, I just need to ignore the deprecation warnings from the CI system.
Describe alternatives you've considered
Perhaps I'm missing some other method of doing Basic Auth with a non-standard transport.
The text was updated successfully, but these errors were encountered: