Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/ExecuteContext, and all the functions that require the argument - deps #536

Open
mdjakovic0920 opened this issue Aug 8, 2024 · 0 comments · May be fixed by #537
Open

Enhance/ExecuteContext, and all the functions that require the argument - deps #536

mdjakovic0920 opened this issue Aug 8, 2024 · 0 comments · May be fixed by #537
Assignees
Labels
enhancement New feature or request

Comments

@mdjakovic0920
Copy link
Contributor

Description

The current implementation of ExecuteContext::new is suitable for already built ADOs.
The functionality of this is to make an instance of execute context from deps, env, info.

By the way, the type of deps is DepsMut and its CustomQuery is Empty as a default. And the already built founctions are implemented the type of deps as DepsMut with CustomQuery = Empty .
This implementation limits its utility in custom ADO that requires deps with not empty CustomQuery.

For example,
To implement the custom ADO that sends orders to Injective Orderbook, for quering from injective, it needs the type of deps as DepsMut<InjectiveQueryWrapper>. Here the generic CustomQuery is InjectiveQueryWrapper.
In this case, ExecuteContext::new requires argument deps with empty CustomQuery, so it occurs an error.

Implementation

To address this, enhancing ExecuteContext, and all the functions that require the argument deps with generic CustomQuery.

Acceptance Criteria

All the functions that require the argument deps should support CustomQuery as a random generic query.

@mdjakovic0920 mdjakovic0920 added the enhancement New feature or request label Aug 8, 2024
@joemonem joemonem linked a pull request Aug 12, 2024 that will close this issue
@joemonem joemonem self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants