Ensure trick play tracks are not merged with incompatible main group

We can only merge groups if they have a clear role flag and language.
If the trick play adaptation set differs, don't merge it to avoid
logcat warnings about invalid track groups.

Issue: #2148
PiperOrigin-RevId: 777539261

Author: tonihei

RELEASENOTES.md

@@ -40,6 +40,9 @@
         and preload hints can cause playback to get stuck or freeze
         ([#2299](https://github.com/androidx/media/issues/2299)).
 *   DASH extension:
+    *   Fix issue where trick-play adaptation set is merged with its main
+        adaptation set to form an invalid `TrackGroup`
+        ([#2148](https://github.com/androidx/media/issues/2148)).
 *   Smooth Streaming extension:
 *   RTSP extension:
     *   Add support for RTP Aggregation Packet for H265 in accordance with RFC

libraries/exoplayer_dash/src/main/java/androidx/media3/exoplayer/dash/DashMediaPeriod.java

@@ -608,7 +608,8 @@ private static int[][] getGroupedAdaptationSetIndices(List<AdaptationSet> adapta
       if (trickPlayProperty != null) {
         long mainAdaptationSetId = Long.parseLong(trickPlayProperty.value);
         @Nullable Integer mainAdaptationSetIndex = adaptationSetIdToIndex.get(mainAdaptationSetId);
-        if (mainAdaptationSetIndex != null) {
+        if (mainAdaptationSetIndex != null
+            && canMergeAdaptationSets(adaptationSet, adaptationSets.get(mainAdaptationSetIndex))) {
           mergedGroupIndex = mainAdaptationSetIndex;
         }
       }
@@ -663,8 +664,10 @@ private static boolean canMergeAdaptationSets(
     }
     Format format1 = adaptationSet1.representations.get(0).format;
     Format format2 = adaptationSet2.representations.get(0).format;
+    int format1RoleFlagsExcludingTrickPlay = format1.roleFlags & ~C.ROLE_FLAG_TRICK_PLAY;
+    int format2RoleFlagsExcludingTrickPlay = format2.roleFlags & ~C.ROLE_FLAG_TRICK_PLAY;
     return Objects.equals(format1.language, format2.language)
-        && format1.roleFlags == format2.roleFlags;
+        && format1RoleFlagsExcludingTrickPlay == format2RoleFlagsExcludingTrickPlay;
   }
 
   /**

libraries/exoplayer_dash/src/test/java/androidx/media3/exoplayer/dash/DashMediaPeriodTest.java

@@ -143,6 +143,32 @@ public void trickPlayProperty_mergesTrackGroups() throws IOException {
     MediaPeriodAsserts.assertTrackGroups(dashMediaPeriod, expectedTrackGroups);
   }
 
+  @Test
+  public void trickPlayProperty_withIncompatibleFormats_mergesOnlyCompatibleTrackGroups()
+      throws IOException {
+    DashManifest manifest = parseManifest("media/mpd/sample_mpd_trick_play_property_incompatible");
+    DashMediaPeriod dashMediaPeriod = createDashMediaPeriod(manifest, 0);
+    List<AdaptationSet> adaptationSets = manifest.getPeriod(0).adaptationSets;
+
+    // We expect the trick play adaptation sets to be merged with the ones to which they refer,
+    // retaining representations in their original order, except when their properties differ.
+    TrackGroupArray expectedTrackGroups =
+        new TrackGroupArray(
+            new TrackGroup(
+                /* id= */ "3000000000",
+                adaptationSets.get(0).representations.get(0).format,
+                adaptationSets.get(0).representations.get(1).format,
+                adaptationSets.get(1).representations.get(0).format),
+            new TrackGroup(
+                /* id= */ "3000000002",
+                adaptationSets.get(2).representations.get(0).format,
+                adaptationSets.get(2).representations.get(1).format),
+            new TrackGroup(
+                /* id= */ "3000000003", adaptationSets.get(3).representations.get(0).format));
+
+    MediaPeriodAsserts.assertTrackGroups(dashMediaPeriod, expectedTrackGroups);
+  }
+
   @Test
   public void adaptationSetSwitchingProperty_andTrickPlayProperty_mergesTrackGroups()
       throws IOException {

libraries/test_data/src/test/assets/media/mpd/sample_mpd_trick_play_property_incompatible

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<MPD availabilityStartTime="2014-06-19T23:07:42" type="dynamic">
+    <Period start="PT7462826.784S" id="0">
+        <AdaptationSet id="3000000000" mimeType="video/mp4">
+            <Role schemeIdUri="urn:mpeg:dash:role:2011" value="main"/>
+            <SupplementalProperty
+                schemeIdUri="http://dashif.org/guidelines/trickmode"
+                value="3000000001"/>
+            <Representation id="0" bandwidth="0" codecs="avc1.42c01f"/>
+            <Representation id="1" bandwidth="1" codecs="avc1.42c01f"/>
+        </AdaptationSet>
+        <AdaptationSet id="3000000001" mimeType="video/mp4">
+            <Role schemeIdUri="urn:mpeg:dash:role:2011" value="main"/>
+            <Representation id="11" bandwidth="100" codecs="avc1.42c01f"/>
+        </AdaptationSet>
+        <AdaptationSet id="3000000002" mimeType="video/mp4">
+            <Role schemeIdUri="urn:mpeg:dash:role:2011" value="main"/>
+            <Representation id="21" bandwidth="200" codecs="avc1.42c01f"/>
+            <Representation id="22" bandwidth="201" codecs="avc1.42c01f"/>
+        </AdaptationSet>
+        <AdaptationSet id="3000000003" mimeType="video/mp4">
+            <Role schemeIdUri="urn:mpeg:dash:role:2011" value="alternate"/>
+            <SupplementalProperty
+              schemeIdUri="http://dashif.org/guidelines/trickmode"
+              value="3000000002"/>
+            <Representation id="31" bandwidth="300" codecs="avc1.42c01f"/>
+        </AdaptationSet>
+    </Period>
+</MPD>