-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear what to do when ResourcesRequest doesn't have resource ids #496
Comments
But it's hard to implement for say a Twitter tile, without remembering which Tiles you returned. |
The documentation says to return all the resources for a given version if the list is empty (I wonder why the list can't just be exhaustive to save developers from having to do this check). It doesn't say why/when it will happen and I wonder if understanding this would be helpful to verify that we (as tile devs) are doing the correct thing for our particular cases. Let's revisit this holistically inc the following comment:
It looks like resource versioning and resource IDs are related, and I think a good outcome for this issue would be a blog post explaining them, with examples. Perhaps in the same post as #495 if it makes sense. |
I think a good approach might be to end with different scenarios that would be good reasons for the following versioning/resource strategies
|
Closing - the TileService never actually receives resource ids, so must generate all images on every request. |
onResourcesRequest(requestParams: ResourcesRequest)
the
requestParams.resourceIds
might be empty. When does this happen? What's the expected behavior from a tile developer in this case?The text was updated successfully, but these errors were encountered: