Skip to content
This repository was archived by the owner on Aug 2, 2024. It is now read-only.

Commit 9a00783

Browse files
authored
Update Glide implementation and item key ID. (#941)
Change-Id: I3d9182d209ac85dc338f2b7b123b2a788e4453ed
1 parent 5f864ae commit 9a00783

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

app/src/main/java/com/google/samples/apps/sunflower/compose/gallery/GalleryScreen.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,14 +107,13 @@ private fun GalleryScreen(
107107
.padding(padding)
108108
.nestedScroll(pullToRefreshState.nestedScrollConnection)
109109
) {
110-
111110
LazyVerticalGrid(
112111
columns = GridCells.Fixed(2),
113112
contentPadding = PaddingValues(all = dimensionResource(id = R.dimen.card_side_margin))
114113
) {
115114
items(
116115
count = pagingItems.itemCount,
117-
key = pagingItems.itemKey { it }
116+
key = pagingItems.itemKey { it.id }
118117
) { index ->
119118
val photo = pagingItems[index] ?: return@items
120119
PhotoListItem(photo = photo) {

app/src/main/java/com/google/samples/apps/sunflower/compose/plantdetail/PlantDetailView.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -326,18 +326,18 @@ private fun PlantImage(
326326
override fun onLoadFailed(
327327
e: GlideException?,
328328
model: Any?,
329-
target: Target<Drawable>?,
329+
target: Target<Drawable>,
330330
isFirstResource: Boolean
331331
): Boolean {
332332
isLoading = false
333333
return false
334334
}
335335

336336
override fun onResourceReady(
337-
resource: Drawable?,
338-
model: Any?,
337+
resource: Drawable,
338+
model: Any,
339339
target: Target<Drawable>?,
340-
dataSource: DataSource?,
340+
dataSource: DataSource,
341341
isFirstResource: Boolean
342342
): Boolean {
343343
isLoading = false
@@ -596,4 +596,4 @@ private fun PlantDetailContentPreview() {
596596
)
597597
}
598598
}
599-
}
599+
}

app/src/main/java/com/google/samples/apps/sunflower/compose/utils/SunflowerImage.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,14 @@ import androidx.compose.foundation.layout.Box
2222
import androidx.compose.foundation.layout.fillMaxWidth
2323
import androidx.compose.foundation.layout.size
2424
import androidx.compose.material3.CircularProgressIndicator
25+
import androidx.compose.material3.MaterialTheme
2526
import androidx.compose.runtime.Composable
2627
import androidx.compose.ui.Alignment
2728
import androidx.compose.ui.Modifier
2829
import androidx.compose.ui.graphics.Color
2930
import androidx.compose.ui.graphics.ColorFilter
3031
import androidx.compose.ui.graphics.DefaultAlpha
32+
import androidx.compose.ui.graphics.painter.ColorPainter
3133
import androidx.compose.ui.layout.ContentScale
3234
import androidx.compose.ui.platform.LocalInspectionMode
3335
import androidx.compose.ui.unit.dp
@@ -65,10 +67,6 @@ fun SunflowerImage(
6567
alpha = alpha,
6668
colorFilter = colorFilter,
6769
requestBuilderTransform = requestBuilderTransform,
68-
loading = placeholder {
69-
Box(modifier.fillMaxWidth(), contentAlignment = Alignment.Center) {
70-
CircularProgressIndicator(Modifier.size(40.dp))
71-
}
72-
}
70+
loading = placeholder(ColorPainter(MaterialTheme.colorScheme.secondary))
7371
)
74-
}
72+
}

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ constraintLayoutCompose = "1.0.1"
2727
coreTesting = "2.2.0"
2828
coroutines = "1.6.4"
2929
espresso = "3.4.0"
30-
glide = "1.0.0-alpha.3"
30+
glide = "1.0.0-beta01"
3131
gradle = "7.2.0"
3232
gson = "2.9.0"
3333
guava = "31.1-android"

0 commit comments

Comments
 (0)