Compose sample for CredentialManager

[yschimke]

Adapting the sample for compose instead of fragments seems complex. I've done this before, but also made mistakes, so a compose sample would help the adoption.

I guess Compose + MAD, such as ViewModels, which complicate where you hoist auth logic and state.

[yschimke]

Found https://github.com/Dashlane/android-passkey-example

Which I have no affiliation with, but is quite helpful.

[niharika2810]

Hi We are working on this, you will get this by next month. The code is in review phase

There's a rough branch which has atleast the Compose and MAD (we are working on a refined MAD practices and clean version), please check glitch_me_sample branch

[yschimke]

Thanks, great news.

Do you want any feedback on it?

[niharika2810]

Hey, are you asking about current branch or the one which we are refining. Once we upload that code on main branch (somewhere in May), please feel free to share the feedback :)

[ber4444]

How is this coming along?

[niharika2810]

Hey this is in review, will be out once done. Thanks!

[aarchish]

Hi We are working on this, you will get this by next month. The code is in review phase

There's a rough branch which has atleast the Compose and MAD (we are working on a refined MAD practices and clean version), please check glitch_me_sample branch

Hello Niharka,
I see that the branch you mention was last updated 1 year ago
you yesterday's comment says "this is in review" - did you mean glitch_me_sample branch with Compose ?

[yschimke]

I believe this means an internal Google review process, that all samples need to go through before they are published to GitHub.

[aarchish]

I believe this means an internal Google review process, that all samples need to go through before they are published to GitHub.

Hello yschimke,
I was specifically asking this in regard to previous context of using Compose and MAD with Credential Manager API

[aarchish]

Hello @niharika2810,

are we still waiting for the PR to go through?

[niharika2810]

Hey we are still refining a few bits. It should be there this week. If you want to see on a high level, you can check the compose branch as of now. Branch name is https://github.com/android/identity-samples/tree/credman-compose/Shrine

We will keep you posted. Internal reviews take some time. THank you all the patience.

[yschimke]

@niharika2810 I tried the Compose sample, it was very simple to use, worked first time. Nice work.

[niharika2810]

Great 😃 Thank you Yuri

…

On Mon, Sep 23, 2024, 3:26 PM Yuri Schimke ***@***.***> wrote: @niharika2810 <https://github.com/niharika2810> I tried the Compose sample, it was very simple to use, worked first time. Nice work. — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJXAH436NHTVO47MGUY6FETZX7QVHAVCNFSM6AAAAABGWMEML6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXG42DCOJXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[yschimke]

Can the sample be merged into the main branch? It's quite hidden.

[JohnUgwuadi]

@yschimke Agreed, I was just looking for this!

[niharika2810]

Yeah right, there are a few features not being ready for Compose. We are waiting on that. This should be merged soon.

@cy245 FYI