Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_LOVD3Database doesn't acquire full list of genes #44

Open
falquaddoomi opened this issue Nov 29, 2016 · 0 comments
Open

_LOVD3Database doesn't acquire full list of genes #44

falquaddoomi opened this issue Nov 29, 2016 · 0 comments

Comments

@falquaddoomi
Copy link

When running extract_data.py against a version 3 LOVD database (http://databases.lovd.nl/shared/, specifically), the method where the list of genes is constructed (https://github.com/andrewhill157/leiden/blob/master/leiden/leiden_database.py#L196) fetches a maximum of 1000 genes, because it only fetches the first page. This causes requests for specific genes via the -o switch to fail if they're not listed on the first page.

I've patched in a fix in my fork, which I will submit shortly as a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant