Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined array key "VERSION" #191

Open
linushstge opened this issue Jun 2, 2024 · 3 comments
Open

Undefined array key "VERSION" #191

linushstge opened this issue Jun 2, 2024 · 3 comments

Comments

@linushstge
Copy link
Contributor

linushstge commented Jun 2, 2024

In the current dev-master there is an issue with an undefined array key version in KeyringFactory.
All requests are failing.

ErrorException
Undefined array key "VERSION"
vendor/andrew-svirin/ebics-client-php/src/Factories/KeyringFactory.php:30

KeyringFactory:

public function createKeyringFromData(array $data): Keyring
    {
        $keyring = new Keyring($data[Keyring::VERSION_PREFIX]);

        $keyring->setUserSignatureA(
            $this->buildKeyringFromDataForTypeKeyring($data, Keyring::USER_PREFIX, Keyring::SIGNATURE_PREFIX_A)
        );

// [...]

https://github.com/andrew-svirin/ebics-client-php/blame/45b39389f4d263aef9255b62d603dd5015227c48/src/Factories/KeyringFactory.php#L30

Error introduced in:
468e44a

Previous commit working fine:
6749bb7

@andrew-svirin
Copy link
Owner

andrew-svirin commented Jun 12, 2024

Yes. It's true.
For the moment old keyrings should be updated manually by new prop version.

Probably readable exception will be added here later.

@linushstge
Copy link
Contributor Author

Hey, can you explain how to upgrade the old keychain?

@andrew-svirin
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants