Skip to content

Commit 4832f3b

Browse files
committed
Code cleanup: Remove unneeded #imports, empty methods, declare id return type when left out, commit irrelevant whitespace flagged as change.
1 parent b6272c0 commit 4832f3b

File tree

8 files changed

+7
-15
lines changed

8 files changed

+7
-15
lines changed

PBCommitList.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ - (NSDragOperation)draggingSourceOperationMaskForLocal:(BOOL) local
2121
- (void)keyDown:(NSEvent *)event
2222
{
2323
NSString* character = [event charactersIgnoringModifiers];
24-
24+
2525
// Pass on command-shift up/down to the responder. We want the splitview to capture this.
2626
if ([event modifierFlags] & NSShiftKeyMask && [event modifierFlags] & NSCommandKeyMask && ([event keyCode] == 0x7E || [event keyCode] == 0x7D)) {
2727
[self.nextResponder keyDown:event];
2828
return;
2929
}
30-
30+
3131
if ([character isEqualToString:@" "]) {
3232
if (controller.selectedCommitDetailsIndex == 0) {
3333
if ([event modifierFlags] & NSShiftKeyMask)

PBGitConfig.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
NSString *repositoryPath;
1515
}
1616
@property (copy) NSString *repositoryPath;
17-
- init;
18-
- initWithRepositoryPath:(NSString *)path;
17+
- (id) init;
18+
- (id) initWithRepositoryPath:(NSString *)path;
1919
@end

PBGitConfig.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
@implementation PBGitConfig
1313
@synthesize repositoryPath;
1414

15-
- init
15+
- (id) init
1616
{
1717
repositoryPath = nil;
1818
return self;
1919
}
2020

21-
- initWithRepositoryPath:(NSString *)path
21+
- (id) initWithRepositoryPath:(NSString *)path
2222
{
2323
repositoryPath = path;
2424
return self;

PBGitRepository.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,6 @@ - (void) addRef: (PBGitRef *) ref fromParameters: (NSArray *) components
250250
- (void) reloadRefs
251251
{
252252
_headRef = nil;
253-
BOOL ret = NO;
254-
255253
refs = [NSMutableDictionary dictionary];
256254
NSMutableArray *oldBranches = [branches mutableCopy];
257255

PBGitSidebarController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ - (id)initWithRepository:(PBGitRepository *)theRepository superController:(PBGit
4242
- (void)awakeFromNib
4343
{
4444
[super awakeFromNib];
45-
window.contentView = self.view;
45+
window.contentView = [self view];
4646
[self populateList];
4747

4848
historyViewController = [[PBGitHistoryController alloc] initWithRepository:repository superController:superController];

PBRefController.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#import "PBRefController.h"
1010
#import "PBGitRevisionCell.h"
1111
#import "PBRefMenuItem.h"
12-
#import "KBPopUpToolbarItem.h"
1312
#import "PBCreateBranchSheet.h"
1413
#import "PBCreateTagSheet.h"
1514
#import "PBGitDefaults.h"

PBViewController.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,4 @@
2828
- (NSResponder *)firstResponder;
2929
- (IBAction) refresh:(id)sender;
3030

31-
- (IBAction) refresh:(id)sender;
3231
@end

PBViewController.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ - (void) updateView
4343
{
4444
}
4545

46-
- (IBAction) refresh: sender
47-
{
48-
}
49-
5046
- (NSResponder *)firstResponder;
5147
{
5248
return nil;

0 commit comments

Comments
 (0)