Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags and versions out of sync #29

Open
sarnold opened this issue May 1, 2021 · 2 comments
Open

tags and versions out of sync #29

sarnold opened this issue May 1, 2021 · 2 comments

Comments

@sarnold
Copy link

sarnold commented May 1, 2021

Either we crossed each other on the last PR or I just plain missed a commit, but upshot is the v0.3.5 commit got orphaned and conda-forge wants to update to v0.3.6 but pypi only has v0.3.5 (the source version is still v0.3.5). I think the best answer is for me to make a PR with version updates and a typo fix for the release page, and then you'll need to delete both the v0.3.5 and v0.3.6 tags, then push a new v0.3.6 tag after the PR merge. Sorry for the inconvenience...

Delete local tag:

git tag --delete <ref_name>

Delete remote tag:

git push origin :<ref_name>
@andreasvc
Copy link
Owner

That sounds like a good plan. You mean that I should delete the tags before I accept your PR?

It's probably my fault. Having to specify the version in multiple places is error prone...

BTW: the github action correctly uploads wheels to pypi, but did not upload the source release.

And a very minor thing: the github releases have versions starting with "vv".

@sarnold
Copy link
Author

sarnold commented May 4, 2021

Actually the conda package version is not so critical, since their automation almost takes care of itself. The PR should take care of that last 2 items above. I'm right in the middle of 17 different things (including trying to spin up a couple of new contracts) but hopefully I can push PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants