Refactor as.*_name functions

[andodet]

As of now, as.*_name functions are a bit of a if/else mess that looks quite garbled and inaccessible. It would be good to go through a round of refactoring to get them more accessible and reduce code duplication. If too much effort, adding some comments to explain the logic might be another way to go.

The following function is how we currently check and format strings to make sure they're a valid subscription name. I am not proud of this:

as.sub_name <- function(x, project = ps_project_get()) {
  # Can it be done with a switch case?
  if (is.character(x) && x != "") {
    if (already_formatted(x)) {
      out <- x
    } else {
      out <- paste(c("projects", project, "subscriptions", x), collapse = "/")
    }
    return(out)
  } else if (inherits(x, "Subscription")) {
    if (already_formatted(x$name)) {
      out <- x$name
    } else {
      out <- paste(c("projects", project, "subscriptions", x$name), collapse = "/")
    }
    return(out)
  } else if (is.null(x)) {
    return(NULL)
  } else {
    stop("Subscription name is invalid!", call. = FALSE)
  }
}

An avenue that might be worth exploring is to have a nameValidator class that will handle name formatting for all entities (topics, subscriptions, schemas, snapshots).

Functions in need of refactoring:

• as.sub_name
• as.topic_name
• as.schema_name
• as.snapshot_name