Consider Module::Build as undeclared prerequisite only if there are no configure phase prereqs declared #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o configure phase prereqs declared
|
It would be good for this to be released, as it is causing confusion in the wild. |
|
Thanks, Karen, for the reminder and Thanks, Dan, in the first place for the patch. Released as 2.34-TRIAL just a minute ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it in line with cpanm's heuristic: https://metacpan.org/source/MIYAGAWA/Menlo-Legacy-1.9022/lib/Menlo/CLI/Compat.pm#L1971
The presence of a Build.PL by itself does not indicate that Module::Build is required (in particular, there are now many Module::Build::Tiny based Build.PLs), and a configure prereq will be added for any other Build.PL based installer.