Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase notarization --wait timeout #354

Open
BirknerAlex opened this issue Apr 11, 2024 · 1 comment
Open

Increase notarization --wait timeout #354

BirknerAlex opened this issue Apr 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@BirknerAlex
Copy link

BirknerAlex commented Apr 11, 2024

What would you like to be added:

Command Line Flag for allowing to set a different timeout, seems like to be at 15 minutes at default.

Why is this needed:

Don't know why but the notarization takes longer then 15 minutes in our case.

$ quill submission list
┌──────────────────────────────────────┬──────────────────────────────────────────────────────────────────────────────────┬─────────────┬──────────────────────────┐
│ ID                                   │ NAME                                                                             │ STATUS      │ CREATED                  │
├──────────────────────────────────────┼──────────────────────────────────────────────────────────────────────────────────┼─────────────┼──────────────────────────┤
│ 0c510253-2a03-472b-ac8f-c0da3ac0f6a7 │ app-edca7e2199c8e982935560ebf5d3071dcf7b85c6e7f87cfd10b110f969ca9a7b-cb544cda │ In Progress │ 2024-04-11T12:58:17.718Z │
│ 4a787033-b066-437b-ac57-dd759e845b63 │ app-ce72c46413e669f30a0797937f9367305c2af7cd25b34a35613fa7dff36f41b5-377f754a │ In Progress │ 2024-04-11T12:58:10.674Z │
└──────────────────────────────────────┴──────────────────────────────────────────────────────────────────────────────────┴─────────────┴──────────────────────────┘

Apple says 98% of the apps should be notarized within 15 minutes. Seems not to be valid in our case. 🤔

Additional context:

I am using goreleaser in my CI pipeline which fails entirely when timing out. Would be awesome to increase the timoeut a little bit further, even if the entire GitHub action runtime increases.

@BirknerAlex BirknerAlex added the enhancement New feature or request label Apr 11, 2024
@wagoodman wagoodman moved this to Ready in OSS May 2, 2024
@andrew-s
Copy link

andrew-s commented Jul 2, 2024

Also experiencing this issue, in fact - every binary we've sent to notarise has taken at least 30 minutes where it times out, this is in a CI system and we're using goreleaser.

Some interesting aspects to this, it seems the timeout can be configured to some degree? Default was 20m, we increased to 30m but it still seems to be taking longer, it's set to 50m but still times out at 30m.

As a side note, we set it to 60m and it returns a 401 Unauthorised error - I haven't dug into the code so I'm not sure where or why 60m would cause a 401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

2 participants