Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixtures have duplicate x509 extension #35

Open
wagoodman opened this issue Apr 8, 2023 · 0 comments
Open

Test fixtures have duplicate x509 extension #35

wagoodman opened this issue Apr 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@wagoodman
Copy link
Contributor

What happened:
When running unit tests with go 1.20 I see the following failure:

--- FAIL: TestSign (2.92s)
    --- FAIL: TestSign/sign_the_syft_binary_(with_a_password) (0.00s)
        sign_test.go:197: 
                Error Trace:    /Users/wagoodman/code/quill/quill/sign_test.go:197
                Error:          Received unexpected error:
                                unable to parse certificate 1 of 1: x509: certificate contains duplicate extensions
                Test:           TestSign/sign_the_syft_binary_(with_a_password)
FAIL

We're on go 1.18 now, bumping to 1.20 you will be able to see the same thing locally.

What you expected to happen:
No test failures!

How to reproduce it (as minimally and precisely as possible):
make unit while using go 1.20.

Anything else we need to know?:
More details on the current change in behavior for x509 certificate verification https://groups.google.com/g/golang-checkins/c/nishT5TtWeo .

@wagoodman wagoodman added the bug Something isn't working label Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant