Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.0] issues found in beta 4 #78

Closed
7 of 15 tasks
anb0s opened this issue Aug 23, 2016 · 9 comments
Closed
7 of 15 tasks

[v2.0] issues found in beta 4 #78

anb0s opened this issue Aug 23, 2016 · 9 comments

Comments

@anb0s
Copy link
Owner

anb0s commented Aug 23, 2016

I need help with testing of the next test release beta 4
tag: V2_0_0_BETA_4
commit: be7ff84

It is available at the testing site now:
http://anb0s.github.io/EasyShell/testing
version: EasyShell 2.0.0.v20160823-1756

image

open issues (verified, new, fixed for next beta):

needed for release:

@rhewitt
Copy link

rhewitt commented Aug 31, 2016

Hi I'm interested in helping test. I have eclipse neon with no prior install (i.e., no v1.4). Will that be useful or do you need prior install for testing? (edited to remove link problem, which I just realized is an eclipse download link...doh!)

@anb0s
Copy link
Owner Author

anb0s commented Aug 31, 2016

Hi, yes, it would be good to have more beta testers :)
No you need no prior install of EasyShell and can just see if the autodetect of OS and tools is working for your case. For next beta 5 or RC1 i will add handling for prior installations (issue #55) and then it can be tested too. I've no MacOSX here, so it would be perfect to have testers here! Linux and Windows testers are welcome too :)
Thanks!

P.S.: yes the site "http://anb0s.github.io/EasyShell/testing" has no web-page, just the eclipse update site. The "http://anb0s.github.io/EasyShell" has both...

@rhewitt
Copy link

rhewitt commented Sep 1, 2016

Ok, good.
OS is Win7 64bit. Sorry, no OSX! Eclipse is freshly downloaded neon w/JavaEE.

Installing beta from test site via eclipse was smooth. EasyShell Version displays as 2.0.0v20160823-1756.

I created a dummy project with a DoNothing class. Opened file explorer and shell with EasyShell by right clicking the java file. Both opened at the correct location.

I made a batch script that appends to a file and ran that through EasyShell's right-click menu (worked). The two path-copy options also worked (pasted to notepad to make sure).

Please let me know what else you'd like me to do. So far everything just works.

@anb0s
Copy link
Owner Author

anb0s commented Sep 1, 2016

Thank You!

If you want and need support for other tools also included in EasyShell, like PowerShell, Git Bash etc. You can try to add them to EasyShell menu in preferences. Additionally try to add new Tools/Commands and use them in menus. The GUI is not final and my feeling is it's not very intuitive now...

You can look at open issues above and comment if miss this things too...

@rhewitt
Copy link

rhewitt commented Sep 1, 2016

Was unable to test git bash preset because the location of the executable is not editable in the preferences -- or at least I didn't see any way to change it. I keep programs in version subfolders, and use envars to establish version to use (e.g., JAVA_HOME).

Was able to add the PowerShell preset and it works from the right-click menu. So that basic paradigm is working and failures are as-designed.

Agree this interface could be improved, but it's certainly usable...no complaints from me. OTOH, my main need is to easily execute external scripts, so I may not be your most demanding user. I do like that what's on the context menu is manageable via preferences with a simple paradigm. That's a nice clean design.

Will play with this more, try adding user-defined commands and look at more issues. Meanwhile, can verify that the issue that brought me here (can't install on neon) is resolved.

Thank you for this plugin! I've been using it on my other computer with eclipse mars to run a build pipeline that concatenates and minifies all the css, html, and javascript for a web app in one click. I see this as very useful for integrating external tools into eclipse when no targeted plugin exists.

@anb0s
Copy link
Owner Author

anb0s commented Sep 2, 2016

Thank You!

Was unable to test git bash preset because the location of the executable is not editable in the preferences -- or at least I didn't see any way to change it.

Yes, this is not intuitive. The concept was to keep plugin defined commands not editable. So only copy to "user defined" and edit then is possible: Menu -> select Bash preset -> Edit... -> Command Copy...
image

and now edit the command line:
image

So the menues and commands can be copied and adapted by user. Now you have new command with "(User)" psotfix that is assigned to the menu. You can remove it with "Remove..." and select other command for the menu.

image

May be it would be better to name the "Copy..." button as "Edit..." and just create a user defined copy of command for adaptions if user changes something in the dialog. "Show..." can be removed then... The only decision i have to made if both "Plugin" and "User" defined command for same tool should be shown in the list or only overridden "User" defined, because it should override the "Plugin" defined one... what do you think?

This all is about the User adaption in general. Your need to just change the location of one tool is clear for me and i've the same with different computers / OS :) It's related to #49 where i want to address such adaptions:

  • search paths (user may override or extend them)
    Then it should be easier to just add (override) the location of one tool (e.g. Git, ConEmu etc.) without changing the command line...

I keep programs in version subfolders, and use envars to establish version to use (e.g., JAVA_HOME).

EasyShell 2.x should support all variables defined in Eclipse for env vars just use e.g. ${env_var:JAVA_HOME} or ${env_var:GIT_HOME} etc. It will be addressed with UI see #75 or #48

@anb0s
Copy link
Owner Author

anb0s commented Sep 2, 2016

Agree this interface could be improved, but it's certainly usable...no complaints from me. OTOH, my main need is to easily execute external scripts, so I may not be your most demanding user. I do like that what's on the context menu is manageable via preferences with a simple paradigm. That's a nice clean design.

Will play with this more, try adding user-defined commands and look at more issues. Meanwhile, can verify that the issue that brought me here (can't install on neon) is resolved.

I need feedback from users independent of exact usage, it will make EasyShell better for "external tool users" in Eclipse. Thank You again!

@anb0s
Copy link
Owner Author

anb0s commented Sep 5, 2016

Created new TODO for command dialog "Copy..." button: #83

@anb0s
Copy link
Owner Author

anb0s commented Sep 19, 2016

done, see #80

@anb0s anb0s closed this as completed Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants