Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Ui suggestions about generate forever and hires fix #85

Open
1 task done
FloriMaster opened this issue Apr 25, 2023 · 5 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@FloriMaster
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Generate forever:

The current way of accessing this feature is quite janky, especially on a mobile device where you have to long-press the Generate button and click on a tiny “Generate forever” button afterward.

Moreover, the current UI doesn’t allow the user to see if the “Generate forever” feature is currently enabled or disabled while generating images. It always shows “cancel generate forever” when you right-click on the “generate” button, regardless if the feature is on or off.

Therefore, I suggest adding a tick box next to the generate button instead of the right-click or long-press method.

Hires fix:

After enabling the Hires fix, a lot of settings such as Hires steps, Upscaler, etc. appear and clutter up the UI. Typically, people don’t change these settings frequently. Unfortunately, there is no way to hide these settings without disabling Hires fix.

To improve this, I suggest adding an arrow button that will hide the settings, similar to what you did with the prompt box.

Proposed workflow

.

Additional information

image
"Generate forever" button when generate forever is off (while generating images)

2023-04-25_14-41
"Generate forever" button when generate forever is on (while generating images)

image
something like this instead would be great

image
something like this for the hires fix button.(i just changed html of the prompt box)

@FloriMaster FloriMaster added the enhancement New feature or request label Apr 25, 2023
@FloriMaster FloriMaster changed the title [Feature Request]: Ui suggestion about generate forever and hires fix [Feature Request]: Ui suggestions about generate forever and hires fix Apr 25, 2023
@anapnoe
Copy link
Owner

anapnoe commented Apr 26, 2023

I like the idea not the checkbox maybe an infinite toggle icon next to generate will work

@Linaqruf
Copy link

Sorry for bringing up this issue. I thought it would be better to ask here instead of creating a new one. I have a problem with the 'generate forever' feature. Recently, my friend asked me about the implementation of 'generate forever,' and I remembered that it already existed. However, when I tried it, there was a bug and the right-click drop-down menu didn't appear correctly. Instead, it appeared under the footer.

image

@anapnoe
Copy link
Owner

anapnoe commented May 18, 2023

yes I am removing context menu and replace with friendly loop button just making the icon :)
my right mouse button doesn't work well need a new one

@anapnoe
Copy link
Owner

anapnoe commented May 19, 2023

I think interrupt serves no purpose when generate forever state is true it seems they do the same think with skip
also if you have a fixed generation seed it will produce the same image over and over don't remember if this was the original implementation the good think is you can modify any value on the fly and in the next generation it will evaluate the new params

@SirVeggie
Copy link

SirVeggie commented Jul 4, 2023

Maybe the interrupt button can stop the infinite generation completely, and skip works as before? It's also fine as is to be honest.

Turning seed to random is annoying when you forget it, but it can also be useful to keep the same seed as you keep tweaking, so no need to change that behaviour.

A dropdown for hires fix might indeed be nice, maybe a like an arrow button next to the hires checkbox that will hide the hires. By default it's not hidden of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants