How to pull request

[AubinMahe]

Hi,

I've made a little update on TextClient.cpp, added lines 527-537 to set type to Video, Iso, Arc, Audio...
How can I create a pull request?
I've already a GitHub account (https://github.com/AubinMahe).

Cheers,
Aubin

[sandrotosi]

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

[AubinMahe]

Note: To open a pull request in a public repository, you must have write access to the head or the source branch or, for organization-owned repositories, you must be a member of the organization that owns the repository to open a pull request.

[AubinMahe]

$ git push --set-upstream origin amulecmd_search_by_type
Username for 'https://github.com': [email protected]
Password for 'https://[email protected]@github.com': 
remote: Permission to amule-project/amule.git denied to AubinMahe.
fatal: unable to access 'https://github.com/amule-project/amule.git/': The requested URL returned error: 403

[gonosztopi]

Read that doc again, carefully. In short:

1. Create a fork of amule-project/amule
2. Make your changes in your forked repository
3. Create a pull request from your forked repository

[AubinMahe]

Thanks, your crystal clear answer may become a how to contribute to aMule document.

[n1ngu]

Thanks for contributing @AubinMahe ! Also note that this answer may become a how to contribute to (almost) any github repository as long as they are willing to accept contributions! This workflow is almost always the same in github as well as gitlab, bitbucket and any major git platform. Only some picky repos like their issues to be opened and discussed and tagged beforehand, or use an external bugtracker and whatnot, which they will clearly state in a contributing guide. But if not stated otherwise, this workflow is not special to aMule, so I don't see the need to document it anywhere beyond some kind of advertisement to encourage contributors!