New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CertCache.renewed* fields into a sub-struct #400

Open

twifkak opened this issue Feb 28, 2020 · 0 comments

Milestone

v4: Ease of deplo...

Member

twifkak commented Feb 28, 2020

Currently, CertCache has a bunch of fields named foo and renewedFoo, to store info about the old and new certificate (for ACME renewal). Two things:

It's missing renewedOCSP fields, as reported in Do not log an OCSP error in case of cert renewal #399.
It would be nice to refactor all these fields into a struct CertInfo with some methods, and then we could just have two CertInfos, and hopefully reduce some code duplication.

twifkak added this to the v4: Ease of deployment milestone

twifkak added the fixit label

twifkak removed the fixit label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment