Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi domain cert/key support #374

Closed
wants to merge 5 commits into from
Closed

multi domain cert/key support #374

wants to merge 5 commits into from

Conversation

alabiaga
Copy link

@alabiaga alabiaga commented Nov 19, 2019 •
edited
Loading

Fixes: #363

Tested on alabiaga.dev and beebo.red domains with the following config:

CertFile = './certs/beebo-red/certfile.pem'
KeyFile = './certs/beebo-red/keyfile.pem'
...
[[URLSet]]
  [URLSet.Sign]
     Domain = "beebo.red" # Uses top level defined cert and key

[[URLSet]]
  [URLSet.Sign]
    Domain = "alabiaga.dev"
    CertFile = './certs/alabiaga-dev/certfile.pem' # Sign level defined CertFile
    KeyFile = './certs/alabiaga-dev/keyfile.pem' # Sign level defined KeyFile

@alabiaga alabiaga mentioned this pull request Nov 22, 2019
Open
@alabiaga alabiaga mentioned this pull request Dec 5, 2019
Merged
@alabiaga
Copy link
Author

alabiaga commented Dec 5, 2019

@twifkak pls don't review this yet, as changes in #361 will require further changes to this PR.

@alabiaga
Copy link
Author

Closing, as #361 will require for additional changes and also this PR alone actually did not suffice to fully support multi cert config

@alabiaga alabiaga closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple certs in configuration
2 participants
@alabiaga @googlebot