Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Updated Neodata configuration to include GDPR in pageview and added new cookiematching #40245

Conversation

RosadiniGianluca
Copy link
Contributor

We need to update the Neodata vendor configuration with these new features:

  1. Add GDPR Consent to Pageview
  2. Add ADFORM Cookie Matching
  3. Add MEDIAMATH Cookie Matching

Thank you for you cooperation.

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2025

CLA assistant check
All committers have signed the CLA.

@powerivq
Copy link
Contributor

Hi,

Please sign the CLA. Also please fix the test failures.

@ychsieh ychsieh requested a review from powerivq February 20, 2025 19:17
@RosadiniGianluca
Copy link
Contributor Author

Hi,

Please sign the CLA. Also please fix the test failures.

@powerivq Thank you for your kind reply.

I have signed the CLA and successfully fixed the test failures related to our Neodata configuration. However, the test is now failing during the "installing Firefox" step.

It returns a 404 error when attempting to install Firefox, which makes me think it might be trying to fetch an outdated version. Unfortunately, I have no idea where the installation script is located or how to modify it.

Could you please provide some support or guidance on how to resolve this issue? I’d really appreciate any help to get this test passing.

Thanks in advance!

@powerivq
Copy link
Contributor

@RosadiniGianluca We are aware of this and working on it.

@powerivq
Copy link
Contributor

@RosadiniGianluca Please rebase against the latest main branch. The fix is in.

@powerivq powerivq force-pushed the update-neodata-amp-consent-configuration branch from 14846db to c8f1da4 Compare February 24, 2025 21:11
@powerivq powerivq merged commit e742aa1 into ampproject:main Feb 24, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants