Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Windows configuration loader #70

Open
kelunik opened this issue Jan 11, 2018 · 2 comments
Open

Improve Windows configuration loader #70

kelunik opened this issue Jan 11, 2018 · 2 comments
Labels
feature request v2

Comments

@kelunik
Copy link
Member

kelunik commented Jan 11, 2018

From kelunik/acme-client#64 (comment):

The issue is in HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\Interfaces. Check NameServer and DhcpNameServer properties in all subkeys and remove or correct the ones which are wrong. The first one found will win, no matter if its available or not.

I think vendor\amphp\dns\lib\DefaultResolver.php#loadResolvConf function should check if the nameserver is available before using it. Or find a better way in windows to get the correct nameserver because the interfaces in this subkey where not consistent with the the interfaces listed elsewhere, also windows itself did not use this nameserver found by this function.
This was referenced Jan 11, 2018
Closed
Closed
@kelunik
Copy link
Member Author

kelunik commented Feb 26, 2018 •
edited
Loading

We should investigate using WMIC, see reactphp/dns#94.

@kelunik kelunik added the v2 label Jan 12, 2023
@Bilge
Copy link
Contributor

Bilge commented Feb 5, 2024 •
edited
Loading

LOL?

The original issue is fixed in #114. WMIC is implemented in #115. An alternative based on PowerShell is implemented in #116. The latter two are just different interfaces for WMI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request v2
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bilge @kelunik