Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output files contain non-readable artifacts #21

Open
jstokes opened this issue Aug 9, 2018 · 0 comments
Open

Output files contain non-readable artifacts #21

jstokes opened this issue Aug 9, 2018 · 0 comments
Assignees

Comments

@jstokes
Copy link
Member

jstokes commented Aug 9, 2018

Output report files from Greenlight contain non-EDN readable artifacts. One such instance are test assertions that are passes

{:actual (#<Fn@1bc9f6 clojure.core/odd_QMARK_> 3),
 :expected (odd? 3),
 :message nil,
 :type :pass}

as the :actual value can't be read using clojure.edn/read-string. The underlying issue is described in https://dev.clojure.org/jira/browse/CLJ-1379.

Before writing output result files, we should clean up these instances as well as any other non-serializable values (exceptions) such that we can read output files.

@jstokes jstokes self-assigned this Aug 9, 2018
@jstokes jstokes changed the title Output files contiain non-readable artifacts Output files contain non-readable artifacts Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant