Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogC4 to CSC #137

Closed
wants to merge 1 commit into from
Closed

Add LogC4 to CSC #137

wants to merge 1 commit into from

Conversation

nick-shaw
Copy link
Contributor

ARRI LogC4 has been added to the IDTs, but not to the CSCs. This PR adds it to the CSCs as well, for completeness.

@nick-shaw
Copy link
Contributor Author

nick-shaw commented Aug 2, 2023

@scoopxyz it would be good to get your eyes on this.

The LogC4 to ACES is pretty much a copy of the IDT, except it uses the same CTL calculate_rgb_to_rgb_matrix function that the other CSCs use, rather than declaring matrix values in the code. The other is the same, but edited to invert things.

@nick-shaw
Copy link
Contributor Author

In my testing, the use of calculate_rgb_to_rgb_matrix means that there are some very small differences in the lower decimal places between using the IDT and the CSC. But this is the case with all the CSCs. Arguably all the IDTs should use that same function too, so as not to limit the matrix to varying arbitrary precision, as the different manufacturer IDTs do.

@JoshkVFX
Copy link

JoshkVFX commented Aug 9, 2023

Hi all,

We're currently facing this same thing on a project we're running right now and would love to see this get through

Thanks,
Josh

@scoopxyz
Copy link
Contributor

Hi Nick, just acknowledging that I've seen this but haven't had the time to validate it myself. It sounds logical to continue using the derivation of matrices in the same fashion as the the other CSC spaces.

@CLAassistant
Copy link

CLAassistant commented May 4, 2024

CLA assistant check
All committers have signed the CLA.

@scottdyer scottdyer added the v1.x label Jul 20, 2024
@scoopxyz
Copy link
Contributor

Just looping back here, although this specific PR may not be relevant now with the repo restructuring, that the implementation looks correct and matches the CTL code provided in the LogC4 white paper.

@scottdyer
Copy link
Contributor

The LogC4 CSCs can be seen here https://github.com/ampas/aces-input-and-colorspaces/tree/main/arri

@scottdyer scottdyer closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants