Skip to content

Commit

Permalink
Add upload metrics to speedtest_dotnet
Browse files Browse the repository at this point in the history
  • Loading branch information
amorphic committed Oct 15, 2023
1 parent a8ecfa5 commit 1a893cf
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 7 deletions.
18 changes: 12 additions & 6 deletions netmeasure/measurements/speedtest_dotnet/measurements.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ def __init__(self, id, servers=None):
self.id = id
self.servers = servers

def measure(self, share=False):
def measure(self, share=False, upload=True, download=True):
"""
@params share: Boolean determining whether to generate a PNG on speedtest.net displaying the result of the test.
param share: Boolean determining whether to generate a PNG on speedtest.net displaying the result of the test.
param upload: Perform upload test.
param download: Perform download test.
"""
try:
s = speedtest.Speedtest()
Expand All @@ -42,10 +44,10 @@ def measure(self, share=False):
s.get_best_server()
except speedtest.SpeedtestBestServerFailure as e:
return self._get_speedtest_error("speedtest-best-server", traceback=str(e))

s.download()
s.upload()

if upload:
s.upload()
if download:
s.download()
if share:
try:
s.results.share()
Expand All @@ -62,6 +64,8 @@ def measure(self, share=False):
upload_rate_unit=NetworkUnit("bit/s"),
data_received=(results_dict["bytes_received"]),
data_received_unit=StorageUnit("B"),
data_sent=(results_dict["bytes_sent"]),
data_sent_unit=StorageUnit("B"),
latency=float(results_dict["ping"]),
server_name=results_dict["server"]["name"],
server_id=results_dict["server"]["id"],
Expand All @@ -81,6 +85,8 @@ def _get_speedtest_error(self, key, traceback):
upload_rate_unit=None,
data_received=None,
data_received_unit=None,
data_sent=None,
data_sent_unit=None,
latency=None,
server_name=None,
server_id=None,
Expand Down
6 changes: 5 additions & 1 deletion netmeasure/measurements/speedtest_dotnet/results.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ class SpeedtestDotnetMeasurementResult(MeasurementResult):
:param download_rate_unit: The unit of measurement of `download_rate`.
:param upload_rate: The measured upload rate.
:param upload_rate_unit: The unit of measurement of `upload_rate`.
:param data_received: The quantity of data report by the speedtest utility
:param data_received: The quantity of data received by the speedtest utility
:param data_received_unit: The unit of measurement of `data_received`
:param data_sent: The quantity of data sent by the speedtest utility
:param data_sent_unit: The unit of measurement of `data_received`
:param latency: The measured latency.
:param server_name: The name of the speedtest.net server used to perform
the speedtest_dotnet measurement.
Expand All @@ -32,6 +34,8 @@ class SpeedtestDotnetMeasurementResult(MeasurementResult):
upload_rate_unit: typing.Optional[NetworkUnit]
data_received: typing.Optional[float]
data_received_unit: typing.Optional[StorageUnit]
data_sent: typing.Optional[float]
data_sent_unit: typing.Optional[StorageUnit]
latency: typing.Optional[float]
server_name: typing.Optional[str]
server_id: typing.Optional[str]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ def setUp(self) -> None:
upload_rate_unit=NetworkUnit("bit/s"),
data_received=116746522,
data_received_unit=StorageUnit("B"),
data_sent=25591808,
data_sent_unit=StorageUnit("B"),
latency=17.054,
server_name="HonestyVille",
server_id="1267",
Expand All @@ -79,6 +81,8 @@ def setUp(self) -> None:
upload_rate_unit=None,
data_received=None,
data_received_unit=None,
data_sent=None,
data_sent_unit=None,
latency=None,
server_name=None,
server_id=None,
Expand All @@ -100,6 +104,8 @@ def setUp(self) -> None:
upload_rate_unit=None,
data_received=None,
data_received_unit=None,
data_sent=None,
data_sent_unit=None,
latency=None,
server_name=None,
server_id=None,
Expand All @@ -121,6 +127,8 @@ def setUp(self) -> None:
upload_rate_unit=None,
data_received=None,
data_received_unit=None,
data_sent=None,
data_sent_unit=None,
latency=None,
server_name=None,
server_id=None,
Expand Down

0 comments on commit 1a893cf

Please sign in to comment.