Use roles from collection, add ubuntu 22.04 and various fixes.

Author: amolofos

ansible/.ansible-lint renamed to .ansible-lint

@@ -57,6 +57,8 @@ warn_list:
   - skip_this_tag
   - git-latest
   - experimental  # experimental is included in the implicit list
+  - yaml[commas]
+  - yaml[line-length]
   # - role-name
 
 # Offline mode disables installation of requirements.yml

.github/workflows/main.yml

@@ -19,13 +19,16 @@ on:
 
 jobs:
 
-  test:
-    name: Test on docker
+  test_end_to_end:
+    name: Test on various OSes
+
+    runs-on: ubuntu-latest
 
-    runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: true
       matrix:
-        os: [ubuntu-20.04]
+        os: ["ubuntu-20.04", 'ubuntu-22.04']
+        python: ["python3.7", "python3.8", "python3.9", "python3.10"]
 
     steps:
       - uses: actions/checkout@v2
@@ -37,5 +40,27 @@ jobs:
           GIT_BRANCH=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}
           echo "GIT_BRANCH=$GIT_BRANCH" >> $GITHUB_ENV
 
-      - name: Build
-        run: ./docker-entrypoint.sh
+          echo "REPOSITORY=${GITHUB_REPOSITORY#*/}" >> $GITHUB_ENV
+
+      - name: Build docker image
+        run: >
+          docker build \
+            -t automation:${{ matrix.os }} \
+            -f docker/Dockerfile.${{ matrix.os }} \
+            .
+
+      - name: End to end test using locally checkedout code
+        run: >
+          docker run automation:${{ matrix.os }} \
+            -e GIT_BRANCH=$GIT_BRANCH \
+            -e REPOSITORY=$REPOSITORY \
+            -e PYTHON_VERSION=${{ matrix.python }}
+
+      - name: End to end test with code fetch from remote
+        run: >
+          docker run automation:${{ matrix.os }} \
+            -e GIT_BRANCH=$GIT_BRANCH \
+            -e REPOSITORY=$REPOSITORY \
+            -e PYTHON_VERSION=${{ matrix.python }} \
+            rm -f "/opt/automated-workstation/app/scripts/add-cronjob-debian.sh"; \
+            /opt/docker/docker-entrypoint.sh

ansible/.gitignore renamed to .gitignore

@@ -1 +1,3 @@
+# Ansible
 .ansibleFactsCacheDir/*
+*.retry

.yamllint.yml

@@ -0,0 +1,14 @@
+---
+
+extends: default
+
+rules:
+  braces:
+    max-spaces-inside: -1
+
+  commas:
+    # Disable check for space after commas so that we can align our values visually.
+    max-spaces-after: -1
+
+  line-length:
+    max: 160

Dockerfile

@@ -0,0 +1,16 @@
+run:
+	./scripts/one-time-debian.sh
+	./scripts/scheduled-debian.sh
+
+lint:
+	. ./.venv/bin/activate
+	ansible-lint -c .ansible-lint
+
+prepare_env:
+	python3.9 -m venv .venv && \
+		. ./.venv/bin/activate && \
+		pip install --upgrade \
+			pip \
+			ansible \
+			ansible-lint \
+			yamllint

Dockerfile.fullBuild

@@ -1,6 +1,6 @@
 # Overview
 
-This is an effort to provide scripts to setup my workstation in an automated, reproducible way.
+This is an effort to provide scripts to setup my workstation in an automated, reproducible way. The scripts are meant to be generic and parameterised based on the provided group_vars.
 
 ## Status
 [![ubuntu-ci status](https://github.com/amolofos/automated-workstation-setup/workflows/ubuntu-ci/badge.svg)](https://github.com/amolofos/automated-workstation-setup/actions)