Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Private tabs button disappears inside the tab bar when the tab bar is full. #95

Open
kaos-55 opened this issue May 22, 2024 · 1 comment · May be fixed by #96
Open

[BUG] Private tabs button disappears inside the tab bar when the tab bar is full. #95

kaos-55 opened this issue May 22, 2024 · 1 comment · May be fixed by #96
Assignees
Labels
bug Something isn't working

Comments

@kaos-55
Copy link

kaos-55 commented May 22, 2024

Link to the file containing the bug
https://github.com/aminomancer/uc.css.js/blob/master/JS/privateTabs.uc.js

Describe the bug
When the private tab button is placed in front of the new tab button in the tab bar, it disappears as soon as the tab bar is full. To access the private tabs button, scroll to the last tab.

To Reproduce
Steps to reproduce the behavior:

  1. Install de private tab script.
  2. Move the private tab script in front of the new tab button in the tab bar.
  3. Open many tabs until the tab overflow arrows appear.
  4. The private tabs button disappears and is located at the end of the last tab.

Expected behavior
The private tabs button should remain in place when the tab overflow arrows appear

Screenshots

Private.Tab.Firefox.Nightly.128.mp4

Desktop (please complete the following information):

  • OS: Windows 10 22H1
  • Firefox update channel: Nightly
  • Version: 128.0a1

Additional context
This problem does not occur if you place any other button in the same place, for example the new private window button.

@kaos-55 kaos-55 added the bug Something isn't working label May 22, 2024
@kaos-55
Copy link
Author

kaos-55 commented Jun 21, 2024

Again bothering you @aminomancer but I would like to add something I discovered. After testing the script for a while I noticed that one of the script's features does not work properly, the script has a function to keep the history but there are times when it does not work.
I moved the private tab button to the toolbar and apparently that function remains intact, however when firefox is restarted the private tab button returns to its original place (in front of the new tab button), apparently the script forces to keep it in that position.
I want to believe that if the main problem is solved the script will work as usual, it happened before when the script did not work because of a problem with the private tab indicator.

@kaos-55 kaos-55 linked a pull request Jun 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants