Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme switcher label #7

Open
robinmetral opened this issue Nov 26, 2021 · 0 comments
Open

Theme switcher label #7

robinmetral opened this issue Nov 26, 2021 · 0 comments

Comments

@robinmetral
Copy link

Shouldn't the theme switcher button say light when the current theme is dark, and dark when it is light? I think the button label should reflect the button's action, not the current state.

(Ideally the label says something like "switch to X mode" but this is more verbose and you might want to look into visually hidden labels for this—so it's a different issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant