-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace .aprc with .amazing_print.yml #63
Comments
yes, executable code in .aprc can possibly allow code injection attacks (one reason why I never kept awesome_print enabled in production. Another reason being that it was was triggering severe performance issues in some situations, by simply having gem loaded into process; don't know if amazing_print has inherited those performance issues). |
The current fixed |
+1 for using Rubocop-style config loading. I was about to open an issue for supporting an XDG base directory aware config path ( @paddor OTOH if work on this issue is not likely any time soon, let me know if a PR for just adding XDG base dir support would have a chance of getting accepted. |
I don't have a strong opinion about this. XDG seems like a good idea. PR welcome. |
To avoid conflicts like #54 I think we should stop using
.aprc
and use a new file in YAML format like Rubocop does.We could support loading files from multiple places. See https://github.com/rubocop-hq/rubocop/blob/master/lib/rubocop/config_loader.rb
This is also more safe since today any Ruby code in
.aprc
is executed.The text was updated successfully, but these errors were encountered: