Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruby19_syntax by default #47

Open
dishcandanty opened this issue Jul 22, 2020 · 4 comments
Open

Enable ruby19_syntax by default #47

dishcandanty opened this issue Jul 22, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@dishcandanty
Copy link

I imagine this is somewhat of a breaking change. But wondering if there's any reason why this wouldn't be enabled by default in 2020.

@fig
Copy link
Contributor

fig commented Sep 27, 2020

Are you referring to symbols as Hash keys?

{ :foo => 'bar' } vs { foo: 'bar' }

If so, the general fashion within the community appears to use 1.9 syntax for source code but use hash rockets for output. FWIW, I'm quite happy to keep it that way.

@dishcandanty
Copy link
Author

Yup! ruby19_syntax: false => ruby19_syntax: true. I hadn't really paid attention if that was generally accepted within the community. I just like being able to copy and paste the output, without it being an immediate rubocop violation.

@HarlemSquirrel
Copy link
Member

@paddor I'm OK making ruby19 syntax the default for the next minor version bump if you are but we may also want to rework this into something like hash_format to support JSON for #70

@HarlemSquirrel HarlemSquirrel added the enhancement New feature or request label Oct 6, 2021
@paddor
Copy link
Contributor

paddor commented Oct 6, 2021

@HarlemSquirrel Yeah, let's do that. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants