Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar selection and rotation fixes #345

Closed
wants to merge 4 commits into from
Closed

Search bar selection and rotation fixes #345

wants to merge 4 commits into from

Conversation

anubhavpulkit
Copy link
Contributor

Description

This Pull Request solve the issue of search bar navigation, Unresponsive search box and Duplication or triplication of the search icon at the top right.

Fixes #332

Type of Change:

  • Code
  • Quality Assurance

How Has This Been Tested?

search-bar

@cpg
Copy link
Member

cpg commented Aug 10, 2020

My suggestions are:

  • Autofocus of the search box -- so that the user does not have to tap twice
  • The second issue is some space below the search box and the rest of the image, when the search box is not cursor-focused

@cpg cpg changed the title search bar Search bar selection and rotation fixes Aug 10, 2020
@anubhavpulkit
Copy link
Contributor Author

My suggestions are:

  • Autofocus of the search box -- so that the user does not have to tap twice
  • The second issue is some space below the search box and the rest of the image, when the search box is not cursor-focused

@cpg I think again about autofocus and find that in our scenario we use the search button to just open the search bar. So we have to tap again on the search bar to type(input) on the search bar. I think we don't have any case to autofocus search bar by just tapping on the search button.

@cpg
Copy link
Member

cpg commented Aug 11, 2020

I cannot parse that English well. It sounds like that language implies there are no other apps showing autofocus, therefore we should not do it?

The google calendar app has a search icon that brings up the search bar with the cursor set and the focus on, bringing up the keyboard immediately.

In any case, right now just displaying an intermediate box (with no text at all inside or a cancel text; like what it does once we tap it) with wrong margins seems weird in terms of UX.

@cpg
Copy link
Member

cpg commented Aug 11, 2020

Also, if one pulls down on the main screen of the iPhone, a search box already focused and with the keyboard comes up.

@anubhavpulkit
Copy link
Contributor Author

Also, if one pulls down on the main screen of the iPhone, a search box already focused and with the keyboard comes up.

We can do this through a design pattern concept called the first responder. And I'm working on this most probably I will update this PR tonight with autofocus functionality(search box already focused and with the keyboard comes up).

@cpg
Copy link
Member

cpg commented Aug 13, 2020

No progress.

@cpg cpg closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search textfield is not working
2 participants