-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Non-Admin User Support #563
base: beta
Are you sure you want to change the base?
Conversation
# Conflicts: # src/main/java/org/amahi/anywhere/AmahiModule.java # src/main/java/org/amahi/anywhere/activity/AuthenticationActivity.java # src/main/java/org/amahi/anywhere/fragment/NavigationFragment.java # src/main/java/org/amahi/anywhere/server/client/ServerClient.java # src/main/res/layout/layout_authentication.xml # src/main/res/values/strings.xml
Issues with auth_token, will be fixed soon. |
Non-Admin User works fine now. User is able to login by just using a PIN which they can set up at |
@chirag-jn I feel it would be better to replace the normal "EditText" on the PIN Access Fragment and replace them with "TextInputLayout - Floating EditText" with counter enabled and locking it to 4 or 6, alternatively to indicate by a change in color if character exceeds. |
<EditText | ||
android:id="@+id/edit_text_pin" | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:gravity="center" | ||
android:hint="@string/hint_pin" | ||
android:imeOptions="actionGo" | ||
android:inputType="textPassword" | ||
android:textSize="@dimen/text_large" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the codes I recommend you to convert to the UI element I specified.
That seems to be a good change, though note that the length of the pin can be 3-5 |
Corrected issue of navigation bar not visible for non admin user. |
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
No description provided.