don't recurse

Author: alxndrsn

packages/node_modules/pouchdb-adapter-indexeddb/src/allDocs.js

@@ -210,7 +210,7 @@ export default function (txn, metadata, opts, callback) {
     };
   }
 
-  function fetchResults() {
+  async function fetchResults() {
     // There is a risk here with getting all results into memory - if they have multiple
     // revs, then we risk loading loads of extra data which is then discarded.  This is
     // reduced by batching.  This also loads unused data when include_docs is false.
@@ -219,10 +219,17 @@ export default function (txn, metadata, opts, callback) {
     // result size, and (2) not so big it's likely to cause issues.
     const batchSize = 100;
 
-    fetchNextBatch();
+    let kr = keyRange;
+    while (kr) {
+      kr = await fetchNextBatch(keyRange);
+    }
+    if (descending) {
+      results.reverse();
+    }
+    return txn.txn.commit();
 
-    function fetchNextBatch() {
-      dbIndex.getAll(keyRange, batchSize).onsuccess = (e) => {
+    function fetchNextBatch(kr) {
+      dbIndex.getAll(kr, batchSize).onsuccess = (e) => {
         const batch = e.target.result;
         for (let i=0; i<batch.length; ++i) {
           const doc = batch[i];
@@ -235,19 +242,14 @@ export default function (txn, metadata, opts, callback) {
 
         if (batch.length >= batchSize) {
           const lastSeenKey = [ 0, batch[batch.length-1].id ];
-          const startKey = descending ? keyRange.upper : lastSeenKey;
-          const endKey = descending ? lastSeenKey : keyRange.upper;
+          const startKey = descending ? kr.upper : lastSeenKey;
+          const endKey = descending ? lastSeenKey : kr.upper;
           if (startKey[1] !== endKey[1]) {
             const incEnd = descending ? false : inclusiveEnd;
             const incStart = descending ? true : false;
-            keyRange = createKeyRange(startKey, endKey, incStart, incEnd, key, descending);
-            return fetchNextBatch();
+            return createKeyRange(startKey, endKey, incStart, incEnd, key, descending);
           }
         }
-        if (descending) {
-          results.reverse();
-        }
-        return txn.txn.commit();
       };
     }
   }